Feature/message type handler - #64
Merged
Merged
Conversation
staabm
reviewed
Dec 11, 2016
Member
There was a problem hiding this comment.
Per phpdoc $body can either be Frame of string. What values are handled in this Else-branch?
Member
Author
There was a problem hiding this comment.
It's more like a legacy issue here. I'll drop the frame part and break it down to string will get parsed by json_decode and any other input will be wrapped with json_ecnode.
- introduced by myself during a refactoring session...
jmglsn
force-pushed
the
feature/message-type-handler
branch
from
December 18, 2016 11:32
1149263 to
4db9c7e
Compare
- add release notes for 4.2.0
jmglsn
force-pushed
the
feature/message-type-handler
branch
from
December 18, 2016 11:39
4db9c7e to
14331a8
Compare
jmglsn
added a commit
to stomp-php/stomp-php-examples
that referenced
this pull request
Dec 18, 2016
jmglsn
added a commit
to stomp-php/stomp-php-examples
that referenced
this pull request
May 31, 2017
jmglsn
added a commit
to stomp-php/stomp-php-examples
that referenced
this pull request
Jun 11, 2017
* add an example for custom message types (stomp-php/stomp-php#64)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some days ago I was using our stomp library again and found out that it's quite complicated to register own message types.
I added the
FrameFactorywhich gives access to the logic that was previously insidesetFrame. Now it's possible to register own resolver which allows to register domain specific messages.