feat: add connection read/write max bytes configuration option. - #113
Merged
Conversation
staabm
reviewed
Nov 22, 2018
| } | ||
|
|
||
| /** | ||
| * Set the maximum number of bytes to write to a resource |
Member
There was a problem hiding this comment.
the comments of the 2 setter methods should describe why one would want that
e.g. that it seems to fix Amazon Queue
Contributor
Author
There was a problem hiding this comment.
Ok, I will change with this for example:
/**
* Set the maximum number of bytes to write to a resource
*
* This will be useful if you are suffering problems with OpenSSL or Amazon MQ
*
* @param int $maxWriteBytes bytes
*/
It's ok for you?
staabm
reviewed
Nov 22, 2018
| $size = strlen($data); | ||
| $lastByteTime = microtime(true); | ||
| do { | ||
| $written = @fwrite($this->connection, substr($data, $offset), 81920); |
Member
There was a problem hiding this comment.
why did we increase this buffer in this past?
Contributor
Author
There was a problem hiding this comment.
We really had reduced it, previously we trying to write all the message length at once. But still it seems that it was not enough.
jmglsn
approved these changes
Nov 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on previous discussion, #112
Added Connection read/write maximum bytes runtime configuration option in order to prevent any kind of problem with OpenSSL or others unpredictable services/components.