Skip to content

Prefer unsynchronized StringBuilder#474

Merged
stleary merged 1 commit into
stleary:masterfrom
gaul:stringbuilder
Jul 26, 2019
Merged

Prefer unsynchronized StringBuilder#474
stleary merged 1 commit into
stleary:masterfrom
gaul:stringbuilder

Conversation

@gaul
Copy link
Copy Markdown
Contributor

@gaul gaul commented Jul 23, 2019

StringBuffer provides unneeded synchronization. Found via
error-prone.

StringBuffer provides unneeded synchronization.  Found via
error-prone.
@stleary
Copy link
Copy Markdown
Owner

stleary commented Jul 24, 2019

What problem does this code solve?
Replaces an internally used inefficient StringBuffer class

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No, and additional unit tests are not needed.

Was any code refactored in this commit?
No

Review status
Approved, starting 3 day comment window

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants