Skip to content

Testing#45

Merged
douglascrockford merged 2 commits into
stleary:masterfrom
guywithnose:master
Jan 30, 2012
Merged

Testing#45
douglascrockford merged 2 commits into
stleary:masterfrom
guywithnose:master

Conversation

@guywithnose
Copy link
Copy Markdown
Contributor

I added an almost complete set of tests. I also fixed two bugs:

  1. Using Integer.MAX_VALUE in JSONTokener can cause memory issues.
    Refer to http://docs.oracle.com/javase/1.4.2/docs/api/java/io/BufferedReader.html#mark%28int%29
  2. Changed "==" to .equals() in JSONML

@douglascrockford
Copy link
Copy Markdown
Contributor

Thanks.

@douglascrockford
Copy link
Copy Markdown
Contributor

Could you please resubmit with this change:

if (!arrayForm && ("tagName".equals(attribute) || "childNode".equals(attribute))) {

@guywithnose
Copy link
Copy Markdown
Contributor Author

Done

douglascrockford added a commit that referenced this pull request Jan 30, 2012
@douglascrockford douglascrockford merged commit 92038ce into stleary:master Jan 30, 2012
BGehrels pushed a commit to BGehrels/JSON-java that referenced this pull request Apr 29, 2020
Added unit tests for escaped quotes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants