Capacity improvements for internal structures#348
Merged
Conversation
…y information * Update JSONObject to allow best guess for initial capacity.
| */ | ||
| public JSONArray(Collection<?> collection) { | ||
| this.myArrayList = new ArrayList<Object>(); | ||
| this.myArrayList = new ArrayList<Object>(collection == null ? 0 : collection.size()); |
There was a problem hiding this comment.
Better to use an if/else statement here instead of 0 as initial capacity
Contributor
Author
There was a problem hiding this comment.
My thought was that if you pass null, you are probably trying to create an empty JSONArray. But for backwards compatibility it may be better to use the standard capacity. Personally if I'm using this constructor it's because I've already finalized my object somewhere else and I'm just preparing it for serialization. But that generalization may not be what we want to imply.
I'll go ahead and change it.
added 2 commits
June 8, 2017 12:15
…when a null collection is passed
… null map is passed
Owner
|
Looks like a reasonable enhancement, though most users will not likely notice a difference, Don't see a need for additional tests in this case. Starting 3 day window. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes:
What problem does this code solve?
For some operations for JSONArray and JSONObject we already know the end-capacity of our internal structures, however, we grow them dynamically instead. This change reduces dynamic growth operations by providing capacity information ahead of time for certain operations.
Risks
low. If anything, this should be improvements for both CPU and memory for the cases effected by the change.
Changes to the API?
One new protected constructor added to JSONObject to allow specification of the internal hashmap capacity. I didn't feel this was valid as a public constructor as it exposes implementation details of the underlying structure.
Will this require a new release?
No, can be rolled into the next release
Should the documentation be updated?
No
Does it break the unit tests?
No test cases failed on the current master.
Was any code refactored in this commit?
Yes
Review status
ACCEPTED Starting 3 day window