Refactor CDL row serialization for readability#1062
Open
Fahmida-Hossain-Charu wants to merge 2 commits into
Open
Refactor CDL row serialization for readability#1062Fahmida-Hossain-Charu wants to merge 2 commits into
Fahmida-Hossain-Charu wants to merge 2 commits into
Conversation
stleary
reviewed
Jun 17, 2026
stleary
reviewed
Jun 17, 2026
stleary
reviewed
Jun 17, 2026
|
Owner
|
What problem does this code solve? Does the code still compile with Java6? Risks Changes to the API? Will this require a new release? Should the documentation be updated? Does it break the unit tests? Was any code refactored in this commit? Review status Starting 3-day comment window |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors
CDL.rowToString(JSONArray, char)to improve readability while preserving existing behavior.Changes
CDL.Compatibility
Validation
Ran the full test suite successfully:
mvn testRisk
The change is limited to private helper extraction and preserves the existing row serialization logic.