restore-lenient-jsonarray allow consecutive commas and insert null #1061
Open
stleary wants to merge 2 commits into
Open
restore-lenient-jsonarray allow consecutive commas and insert null #1061stleary wants to merge 2 commits into
stleary wants to merge 2 commits into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this code solve?
Fixes a regression: lenient parsing should allow consecutive array commas, and insert a null.
The regression was that non-strictmode was resulting in the array being truncated.
Fixes #1033
Does the code still compile with Java6?
Yes
Risks
Low
Changes to the API?
No
Will this require a new release?
No
Should the documentation be updated?
No
Does it break the unit tests?
No, a new unit test was added. Tested in both regular and strict mode
Was any code refactored in this commit?
No
Review status
APPROVED - By myself
Starting 3-day comment window