Skip to content

Migrate to pyproject.toml#62

Closed
cunla wants to merge 1 commit into
stefankoegl:masterfrom
cunla:master
Closed

Migrate to pyproject.toml#62
cunla wants to merge 1 commit into
stefankoegl:masterfrom
cunla:master

Conversation

@cunla

@cunla cunla commented Jul 23, 2024

Copy link
Copy Markdown
Contributor
  • Migrate to pyproject.toml
    • Using poetry.
    • Defining all project settings in the TOML file.
      • Included package, script, etc. (no need for MANIFEST.in)
      • Dependencies (no need for requirements-dev.txt)
      • Classifiers (no need for setup.py)
      • Authors, maintainers, versions (no need for AUTHORS, setup.cfg)
  • Run black formatter on code files
  • Update GitHub workflow to support new structure.

@cunla

cunla commented Aug 3, 2024

Copy link
Copy Markdown
Contributor Author

@stefankoegl, you have been unresponsive on emails.
Any update on this?

Should we open a PIP541 ticket?

@stefankoegl

Copy link
Copy Markdown
Owner

Hi! I have blocked some time on Monday to look into this.

Btw, on GitHub mobile it currently shows this PR as unable to merge (I don't see any details, though)

@cunla

cunla commented Aug 3, 2024

Copy link
Copy Markdown
Contributor Author

I can't see any merge conflicts here - not sure.
Happy to discuss.

@stefankoegl stefankoegl left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. As I am not familiar with poetry, would you mind documenting (or referencing documentation) for basics such as updating dependencies?

@cunla

cunla commented Aug 6, 2024

Copy link
Copy Markdown
Contributor Author

I'll address this further once added to the pypi package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants