Skip to content

feat!: refactor API and add C API to math/base/special/cfloor#973

Merged
kgryte merged 4 commits into
developfrom
addon-cfloor
Apr 13, 2023
Merged

feat!: refactor API and add C API to math/base/special/cfloor#973
kgryte merged 4 commits into
developfrom
addon-cfloor

Conversation

@steff456
Copy link
Copy Markdown
Contributor

@steff456 steff456 commented Mar 15, 2023

Part of https://github.com/stdlib-js/todo/issues/1454

Description

What is the purpose of this pull request?

This pull request:

  • Removes out keyword
  • Adds support for Complex128 dtype
  • Adds C implementation
  • Adds native addon with benchmark, tests, examples and readme update

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

steff456 added 2 commits March 15, 2023 12:09
@steff456
remove: remove out keyword and add support for Complex128 data type i…
d953f4c 
…nputs

BREAKING CHANGE: out keyword is no longer supported and now cfloor only
works with Complex128 inputs
@steff456
feat: add addon to cfloor package
c27fba1
@steff456 steff456 added Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. labels Mar 15, 2023
@steff456 steff456 requested a review from kgryte March 15, 2023 17:45
@steff456 steff456 self-assigned this Mar 15, 2023
kgryte
kgryte reviewed Apr 13, 2023
View reviewed changes
Comment thread lib/node_modules/@stdlib/math/base/special/cfloor/benchmark/benchmark.js Outdated
kgryte
kgryte reviewed Apr 13, 2023
View reviewed changes
Comment thread lib/node_modules/@stdlib/math/base/special/cfloor/examples/c/Makefile Outdated
kgryte
kgryte reviewed Apr 13, 2023
View reviewed changes
Comment thread lib/node_modules/@stdlib/math/base/special/cfloor/include/stdlib/math/base/special/cfloor.h Outdated
kgryte
kgryte reviewed Apr 13, 2023
View reviewed changes
Comment thread lib/node_modules/@stdlib/math/base/special/cfloor/package.json
kgryte
kgryte reviewed Apr 13, 2023
View reviewed changes
Comment thread lib/node_modules/@stdlib/math/base/special/cfloor/src/Makefile Outdated
kgryte
kgryte reviewed Apr 13, 2023
View reviewed changes
Comment thread lib/node_modules/@stdlib/math/base/special/cfloor/src/main.c Outdated
kgryte
kgryte approved these changes Apr 13, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @steff456!

@kgryte kgryte changed the title add cfloor addon feat!: refactor API and add C API to math/base/special/cfloor Apr 13, 2023
@kgryte kgryte merged commit 8acd137 into develop Apr 13, 2023
@kgryte kgryte deleted the addon-cfloor branch April 13, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

@steff456 steff456

Labels

Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@steff456 @kgryte