Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
Signed-off-by: Athan <kgryte@gmail.com>
  • Loading branch information
kgryte authored Dec 8, 2025
commit 5b5c3e08f9b7467f9f7fe72966d6d1a3030b98a6
Original file line number Diff line number Diff line change
Expand Up @@ -38,18 +38,6 @@ import toReversedDimension = require( './index' );
toReversedDimension( empty( 'uint16', sh, order ), 0 ); // $ExpectType uint16ndarray
toReversedDimension( empty( 'uint8', sh, order ), 0 ); // $ExpectType uint8ndarray
toReversedDimension( empty( 'uint8c', sh, order ), 0 ); // $ExpectType uint8cndarray

toReversedDimension( empty( 'float64', sh, order ), 0 ); // $ExpectType float64ndarray
toReversedDimension( empty( 'float32', sh, order ), 0 ); // $ExpectType float32ndarray
toReversedDimension( empty( 'complex128', sh, order ), 0 ); // $ExpectType complex128ndarray
toReversedDimension( empty( 'complex64', sh, order ), 0 ); // $ExpectType complex64ndarray
toReversedDimension( empty( 'int32', sh, order ), 0 ); // $ExpectType int32ndarray
toReversedDimension( empty( 'int16', sh, order ), 0 ); // $ExpectType int16ndarray
toReversedDimension( empty( 'int8', sh, order ), 0 ); // $ExpectType int8ndarray
toReversedDimension( empty( 'uint32', sh, order ), 0 ); // $ExpectType uint32ndarray
toReversedDimension( empty( 'uint16', sh, order ), 0 ); // $ExpectType uint16ndarray
toReversedDimension( empty( 'uint8', sh, order ), 0 ); // $ExpectType uint8ndarray
toReversedDimension( empty( 'uint8c', sh, order ), 0 ); // $ExpectType uint8cndarray
}

// The compiler throws an error if the function is provided a first argument which is not an ndarray...
Expand All @@ -62,51 +50,20 @@ import toReversedDimension = require( './index' );
toReversedDimension( [], 0 ); // $ExpectError
toReversedDimension( {}, 0 ); // $ExpectError
toReversedDimension( ( x: number ): number => x, 0 ); // $ExpectError

toReversedDimension( '10', 0 ); // $ExpectError
toReversedDimension( 10, 0 ); // $ExpectError
toReversedDimension( false, 0 ); // $ExpectError
toReversedDimension( true, 0 ); // $ExpectError
toReversedDimension( null, 0 ); // $ExpectError
toReversedDimension( [], 0 ); // $ExpectError
toReversedDimension( {}, 0 ); // $ExpectError
toReversedDimension( ( x: number ): number => x, 0 ); // $ExpectError
}

// The compiler throws an error if the function is provided a second argument which is not a number...
{
const x = empty( 'float64', [ 2, 2 ], 'row-major' );

toReversedDimension( x, '5' ); // $ExpectError
toReversedDimension( x ); // $ExpectError
toReversedDimension( x ); // $ExpectError
toReversedDimension( x, true ); // $ExpectError
toReversedDimension( x, false ); // $ExpectError
toReversedDimension( x, null ); // $ExpectError
toReversedDimension( x, undefined ); // $ExpectError
toReversedDimension( x, [ '5' ] ); // $ExpectError
toReversedDimension( x, {} ); // $ExpectError
toReversedDimension( x, ( x: number ): number => x ); // $ExpectError

toReversedDimension( x, '5' ); // $ExpectError
toReversedDimension( x ); // $ExpectError
toReversedDimension( x ); // $ExpectError
toReversedDimension( x, null ); // $ExpectError
toReversedDimension( x, undefined ); // $ExpectError
toReversedDimension( x, [ '5' ] ); // $ExpectError
toReversedDimension( x, {} ); // $ExpectError
toReversedDimension( x, ( x: number ): number => x ); // $ExpectError
}

// The compiler throws an error if the function is provided a third argument which is not a boolean...
{
const x = empty( 'float64', [ 2, 2 ], 'row-major' );

toReversedDimension( x, 0, '5' ); // $ExpectError
toReversedDimension( x, 0, 5 ); // $ExpectError
toReversedDimension( x, 0, null ); // $ExpectError
toReversedDimension( x, 0, undefined ); // $ExpectError
toReversedDimension( x, 0, [ '5' ] ); // $ExpectError
toReversedDimension( x, 0, {} ); // $ExpectError
toReversedDimension( x, 0, ( x: number ): number => x ); // $ExpectError
}

// The compiler throws an error if the function is provided an unsupported number of arguments...
Expand Down