Skip to content

feat: add C implementation for math/base/special/erfinv#731

Merged
Planeshifter merged 15 commits into
stdlib-js:developfrom
Pranavchiku:erfinv_1
Jun 19, 2024
Merged

feat: add C implementation for math/base/special/erfinv#731
Planeshifter merged 15 commits into
stdlib-js:developfrom
Pranavchiku:erfinv_1

Conversation

@Pranavchiku
Copy link
Copy Markdown
Member

@Pranavchiku Pranavchiku commented Dec 17, 2022 •
edited
Loading

Resolves #721.

Checklist

  • update readme.md
  • include.gypi
  • binding.gyp
  • include/stdlib/math/base/special/
  • evalrational.js
  • src
  • manifest.json
  • lib
  • examples
  • benchmark
  • test

@kgryte

@Pranavchiku
Copy link
Copy Markdown
Member Author

Pranavchiku commented Dec 17, 2022

All tests and benchmarks cleared, this PR can have a final review.

@Pranavchiku Pranavchiku marked this pull request as ready for review December 17, 2022 05:18
@Pranavchiku
Copy link
Copy Markdown
Member Author

Pranavchiku commented Dec 17, 2022

Latest implementation 1_81_0/boost/math/special_functions/detail/erf_inv.hpp, I tried to have a look at it, but its quite confusing.

@kgryte
Copy link
Copy Markdown
Member

kgryte commented Dec 17, 2022

@Pranavchiku Indeed, Boost makes heavy use to templating which can be hard to grok. With practice. :)

@Planeshifter Planeshifter changed the title Add C implementation for @stdlib/math/base/special/erfinv feat: add C implementation for math/base/special/erfinv Mar 3, 2024
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. Math Issue or pull request specific to math functionality. C Issue involves or relates to C. labels Mar 17, 2024
@kgryte kgryte self-requested a review March 17, 2024 10:13
@Planeshifter Planeshifter self-requested a review May 23, 2024 02:05
@Planeshifter
Copy link
Copy Markdown
Member

Planeshifter commented Jun 19, 2024

/stdlib update-copyright-years

kgryte
kgryte reviewed Jun 19, 2024
View reviewed changes
Comment thread lib/node_modules/@stdlib/math/base/special/erfinv/examples/c/example.c Outdated
kgryte
kgryte reviewed Jun 19, 2024
View reviewed changes
Comment thread lib/node_modules/@stdlib/math/base/special/erfinv/README.md Outdated
kgryte
kgryte reviewed Jun 19, 2024
View reviewed changes
Comment thread lib/node_modules/@stdlib/math/base/special/erfinv/README.md Outdated
kgryte
kgryte reviewed Jun 19, 2024
View reviewed changes
Comment thread lib/node_modules/@stdlib/math/base/special/erfinv/examples/c/example.c
Planeshifter
Planeshifter approved these changes Jun 19, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in!

@Planeshifter Planeshifter merged commit 7ddca8e into stdlib-js:develop Jun 19, 2024
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte left review comments

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees

No one assigned

Labels

C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/math/base/special/erfinv

3 participants

@Pranavchiku @kgryte @Planeshifter