Conversation
kgryte
reviewed
Jul 20, 2022
kgryte
reviewed
Jul 21, 2022
kgryte
requested changes
Jul 21, 2022
kgryte
left a comment
Member
There was a problem hiding this comment.
@steff456 If you could copy over the tests for negative values, that would be great!
Note, however, that you'll need to add the opts argument to each test, as the native tests can only be run in Node.js environments, not browser environments.
Member
|
May also do a once over to ensure that I was able to scrub all |
kgryte
reviewed
Jul 21, 2022
Member
|
One last thing, would you mind renaming the SVG file such that |
kgryte
reviewed
Jul 21, 2022
Member
|
Awesome! Only |
kgryte
approved these changes
Jul 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #222
Description
This PR adds a package for reciprocal cube root
This pull request:
rcbrtRelated Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers