Skip to content

feat: add ndarray/find#4398

Merged
kgryte merged 15 commits intostdlib-js:developfrom
gururaj1512:ndarray/find
Nov 1, 2025
Merged

feat: add ndarray/find#4398
kgryte merged 15 commits intostdlib-js:developfrom
gururaj1512:ndarray/find

Conversation

@gururaj1512
Copy link
Copy Markdown
Member

@gururaj1512 gururaj1512 commented Dec 30, 2024 •
edited by headlessNode
Loading

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: passed
  • task: lint_package_json status: passed
  • task: lint_repl_help status: passed
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: passed
  • task: lint_javascript_tests status: passed
  • task: lint_javascript_benchmarks status: passed
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: passed
  • task: lint_license_headers status: passed ---

type: pre_push_report
description: Results of running various checks prior to pushing changes. report:

  • task: run_javascript_examples status: passed
  • task: run_c_examples status: na
  • task: run_cpp_examples status: na
  • task: run_javascript_readme_examples status: passed
  • task: run_c_benchmarks status: na
  • task: run_cpp_benchmarks status: na
  • task: run_fortran_benchmarks status: na
  • task: run_javascript_benchmarks status: passed
  • task: run_julia_benchmarks status: na
  • task: run_python_benchmarks status: na
  • task: run_r_benchmarks status: na
  • task: run_javascript_tests status: passed ---

Resolves stdlib-js/metr-issue-tracker#70.

Description

What is the purpose of this pull request?

This pull request:

  • Adds implementation for ndarray/find

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@gururaj1512
feat: add ndarray/find
96241d9 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 30, 2024
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Dec 30, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
ndarray/find $\color{red}367/590$
$\color{green}+62.20\%$ 		$\color{green}5/5$
$\color{green}+100.00\%$ 		$\color{red}0/4$
$\color{green}+0.00\%$ 		$\color{red}367/590$
$\color{green}+62.20\%$

The above coverage report was generated for the changes in this PR.

@kgryte
Copy link
Copy Markdown
Member

kgryte commented Dec 30, 2024 •
edited
Loading

@gururaj1512 Before you start doing too many of things in #2656 and us needing to go back and fix things, I'd put these on pause. As mentioned in #2656, the issue is that find (and every) are reductions, and thus should support specifying axes over which to perform the reductions. And furthermore, the implementation proposed in this PR may work for the flattened case; however, it won't work for the axes case. And lastly, we should always return ndarrays, not scalars. In short, there is a bit of R&D which needs to be done in order for these to move forward.

@kgryte
Copy link
Copy Markdown
Member

kgryte commented Dec 30, 2024

One other thing: each top-level ndarray implementation should be a wrapper around a "base" implementation. Notice how in base/for-each, we write kernels for efficient iteration: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/ndarray/base/for-each/lib. I would expect something similar for reductions.

@kgryte
Copy link
Copy Markdown
Member

kgryte commented Dec 30, 2024

So before top-level implementations, we need to create the "base" implementations.

@kgryte kgryte added the Needs Discussion Needs further discussion. label Dec 30, 2024
@gururaj1512
Copy link
Copy Markdown
Member Author

gururaj1512 commented Dec 30, 2024

@gururaj1512 Before you start doing too many of things in #2656 and us needing to go back and fix things, I'd put these on pause. As mentioned in #2656, the issue is that find (and every) are reductions, and thus should support specifying axes over which to perform the reductions. And furthermore, the implementation proposed in this PR may work for the flattened case; however, it won't work for the axes case. And lastly, we should always return ndarrays, not scalars. In short, there is a bit of R&D which needs to be done in order for these to move forward.

Yaa I had similar doubts while creating this PR. Just created this quick PR to discuss about it.

@gururaj1512
Copy link
Copy Markdown
Member Author

gururaj1512 commented Dec 30, 2024

@kgryte, Should we pause this, or is there something I can work on? I would love to work on issues related to this.

@kgryte
Copy link
Copy Markdown
Member

kgryte commented Dec 30, 2024

@gururaj1512 Yes, let's pause. I pinged you on the tracking issue.

@kgryte kgryte mentioned this pull request Jan 6, 2025
Open
52 tasks
@gururaj1512 gururaj1512 mentioned this pull request Apr 4, 2025
Closed
7 tasks
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Aug 13, 2025

@headlessNode Once #7426 is merged, would you mind taking this PR over, refactoring, and basing on ndarray/base/find?

@kgryte kgryte added Feature Issue or pull request for adding a new feature. status: Blocked Issue or pull request which is currently blocked. Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. Needs Discussion Needs further discussion. labels Aug 13, 2025
@kgryte kgryte requested a review from headlessNode August 13, 2025 02:23
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 13, 2025
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Aug 13, 2025
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Sep 2, 2025

@headlessNode Now that #7426 has been merged, this is now ready for you.

@kgryte kgryte removed the status: Blocked Issue or pull request which is currently blocked. label Sep 2, 2025
@headlessNode
Copy link
Copy Markdown
Member

headlessNode commented Sep 2, 2025

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Sep 2, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Sep 2, 2025
@headlessNode
Copy link
Copy Markdown
Member

headlessNode commented Sep 2, 2025

/stdlib help

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Sep 2, 2025
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Sep 2, 2025

@headlessNode, available slash commands include:

  • /stdlib check-files - Check for required files.
  • /stdlib make-commands - Print make commands for package changed in PR.
  • /stdlib update-copyright-years - Update copyright header years.
  • /stdlib lint-autofix - Auto-fix lint errors.
  • /stdlib merge - Merge changes from develop branch into this PR.
  • /stdlib rebase - Rebase this PR on top of develop branch.

headlessNode
headlessNode reviewed Sep 10, 2025
View reviewed changes
Comment thread lib/node_modules/@stdlib/ndarray/find/README.md Outdated
@headlessNode
fix: lint error
bac6b34 
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
kgryte
kgryte reviewed Sep 11, 2025
View reviewed changes
Comment thread lib/node_modules/@stdlib/ndarray/find/lib/main.js Outdated
kgryte
kgryte reviewed Sep 11, 2025
View reviewed changes
Comment thread lib/node_modules/@stdlib/ndarray/find/lib/main.js Outdated
kgryte
kgryte reviewed Sep 11, 2025
View reviewed changes
Comment thread lib/node_modules/@stdlib/ndarray/find/lib/main.js Outdated
kgryte
kgryte reviewed Sep 11, 2025
View reviewed changes
Comment thread lib/node_modules/@stdlib/ndarray/find/lib/main.js Outdated
kgryte
kgryte reviewed Sep 11, 2025
View reviewed changes
Comment thread lib/node_modules/@stdlib/ndarray/find/lib/assign.js Outdated
kgryte
kgryte reviewed Sep 11, 2025
View reviewed changes
Comment thread lib/node_modules/@stdlib/ndarray/find/lib/assign.js Outdated
kgryte
kgryte reviewed Sep 11, 2025
View reviewed changes
Comment thread lib/node_modules/@stdlib/ndarray/find/lib/assign.js Outdated
kgryte
kgryte reviewed Sep 11, 2025
View reviewed changes
Comment thread lib/node_modules/@stdlib/ndarray/find/lib/assign.js Outdated
kgryte
kgryte reviewed Sep 11, 2025
View reviewed changes
Comment thread lib/node_modules/@stdlib/ndarray/find/lib/assign.js Outdated
@headlessNode headlessNode self-requested a review September 14, 2025 07:19
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Sep 14, 2025
@headlessNode
refactor: apply suggestions from code review
ec79858 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@headlessNode
refactor: apply suggestions from code review
67bdae8 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@headlessNode
refactor: apply suggestions from code review
c77ba17 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@headlessNode
refactor: apply suggestions from code review
b1d50c3 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@headlessNode
refactor: apply suggestions from code review
510423d 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@headlessNode headlessNode marked this pull request as ready for review September 14, 2025 12:22
@headlessNode headlessNode requested a review from kgryte September 14, 2025 12:23
@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Sep 14, 2025
@headlessNode headlessNode mentioned this pull request Sep 16, 2025
Closed
@headlessNode
Copy link
Copy Markdown
Member

headlessNode commented Sep 26, 2025

@kgryte ping

@kgryte
chore: clean-up
3023106 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Nov 1, 2025
kgryte
kgryte previously approved these changes Nov 1, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up.

@kgryte
docs: fix examples
ab0f0a7 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@kgryte kgryte merged commit f8c51b3 into stdlib-js:develop Nov 1, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

@headlessNode headlessNode Awaiting requested review from headlessNode

Assignees

No one assigned

Labels

Feature Issue or pull request for adding a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: Add ndarray/find

4 participants

@gururaj1512 @stdlib-bot @kgryte @headlessNode