Change '/' to path.sep in postinstall script#352
Merged
Conversation
On Windows, package.json ends up with a bunch of "\\" in the dependencies, which breaks npm install after the first installation. This should fix that.
kgryte
approved these changes
Aug 10, 2020
Member
|
LGTM. I'll try to publish a new release in the coming days. |
Contributor
Author
|
@kgryte any update on when a new release will get published? 🙂 |
Member
|
Ah! Sorry. I can publish a new version later today. |
Member
|
Thanks for the nudge! |
Member
|
New release published. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, the postinstall script causes the package.json of any project depending on @stdlib/stdlib to end up with a bunch of "\\" in the dependency names, which breaks npm install after the first installation.
Resolves #351 .
Checklist
develop.developbranch.Description
This pull request:
npm installon Windows when @stdlib/stdlib is a package dependencyRelated Issues
No.
This pull request:
npm installon Windows when @stdlib/stdlib is a dependency #351Questions
No.
Other
No.
@stdlib-js/reviewers