feat!: update the return value for `n=1` in `math/base/special/bernoulli`#3108

Merged

kgryte merged 8 commits into

stdlib-js:developfrom

gunjjoshi:bernoulli

Nov 14, 2024

Member

gunjjoshi commented Nov 13, 2024 •

edited

Loading

Description

What is the purpose of this pull request?

This pull request:

addresses the discussion at feat: add math/base/special/bernoullif #3037 (comment)
adds a conditional statement to check if n = 1, and return 0.5 in math/base/special/bernoulli.
adds the corresponding test.
modifies the examples accordingly.
updates benchmarks and tests according to the latest conventions.

Related Issues

Does this pull request have any related issues?

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers


          refactor: return 0.5 when n is 1

3e9c7d7

stdlib-bot added the Math label

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/math/base/special/bernoulli/benchmark/c/native/benchmark.c Outdated

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/math/base/special/bernoulli/src/main.c Outdated

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/math/base/special/bernoulli/test/test.js Outdated

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/math/base/special/bernoulli/test/test.js Outdated

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/math/base/special/bernoulli/test/test.native.js Outdated

kgryte changed the title ~~refactor: correct return value for n=1 in math/base/special/bernoulli~~ feat!: update the return value for n=1 in math/base/special/bernoulli

kgryte added the release: Major label

Member

kgryte commented Nov 13, 2024

Note that this change is not a "refactor", per se, but a breaking change. Upon merging, we will need to articulate that breaking change to ensure that the changelog is populated correctly.

kgryte added the Needs Changes label

kgryte mentioned this pull request

feat: add math/base/special/bernoullif #3037

Merged

1 task

gunjjoshi and others added 6 commits

November 14, 2024 07:59


          Update lib/node_modules/@stdlib/math/base/special/bernoulli/benchmark…

21687b2

…/c/native/benchmark.c

Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>


          Update lib/node_modules/@stdlib/math/base/special/bernoulli/test/test.js

b301605

Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>


          Update lib/node_modules/@stdlib/math/base/special/bernoulli/test/test…

5f291d6

….native.js

Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>


          Update lib/node_modules/@stdlib/math/base/special/bernoulli/test/test.js

338213e

Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>


          Update main.c

6b5e320

Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>


          Update manifest.json

11ab39f

Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>

Member Author

gunjjoshi commented Nov 14, 2024

Note that this change is not a "refactor", per se, but a breaking change. Upon merging, we will need to articulate that breaking change to ensure that the changelog is populated correctly.

Got it, thanks for explaining!

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/math/base/special/bernoulli/test/test.native.js Outdated


          Fix test

6331ceb

Signed-off-by: Athan <kgryte@gmail.com>

kgryte approved these changes

View reviewed changes

Member

kgryte left a comment

LGTM. Thanks, @gunjjoshi!

kgryte removed the Needs Changes label

kgryte merged commit 47cfa90 into stdlib-js:develop

gunjjoshi deleted the bernoulli branch

August 23, 2025 18:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Math release: Major