test: add tests to ndarray/base/nullary#2663
Merged
Merged
Conversation
Member
Author
|
@kgryte Please review, thanks. |
Member
Yeah, not sure. Would need to investigate. It's possible that the sort is unstable or the particular combo of shape/strides worked out. Regardless, thank you for making the changes. |
kgryte
approved these changes
Jul 25, 2024
Member
kgryte
left a comment
There was a problem hiding this comment.
LGTM. Thanks, @headlessNode! It's great that we now have 100% code in this package!
gunjjoshi
pushed a commit
to gunjjoshi/stdlib
that referenced
this pull request
Aug 21, 2024
PR-URL: stdlib-js#2663 Closes: stdlib-js#2229 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2229 .
Description
This pull request:
@stdlib/ndarray/base/nullary/test/test.10d.jsfor 100% test coverageRelated Issues
This pull request:
@stdlib/ndarray/base/nullary#2229Questions
No.
Other
9d, i.e.[ 2, 1, 2, 1, bsize*2, 2, 1, 2, 1, 2 ](only one alternate side of the dimensionbsize*2was non-singleton) and same as with9dI was getting100%branch coverage (screenshot below). Could you comment on why this is happening?Checklist
@stdlib-js/reviewers