feat: add C implementation for math/base/special/spence#2298
Merged
kgryte merged 8 commits intostdlib-js:developfrom Jun 7, 2024
gunjjoshi:spence
Merged
feat: add C implementation for math/base/special/spence#2298kgryte merged 8 commits intostdlib-js:developfrom gunjjoshi:spence
math/base/special/spence#2298kgryte merged 8 commits intostdlib-js:developfrom
gunjjoshi:spence
Conversation
Member
Author
|
While implementing this, a bit higher tolerance was required in the tests. I checked the implementation with that of |
Planeshifter
reviewed
Jun 3, 2024
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
approved these changes
Jun 3, 2024
Member
Planeshifter
left a comment
There was a problem hiding this comment.
Looks good to me, will merge after CI checks have passed (updated @returns to @return in C function documentation.)
kgryte
reviewed
Jun 3, 2024
kgryte
reviewed
Jun 3, 2024
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
requested changes
Jun 3, 2024
Member
kgryte
left a comment
There was a problem hiding this comment.
Overall, this is good; however, we should investigate the test tolerance discrepancy before merging.
Member
|
This PR also supersedes #968. Thus, once this PR is merged, the other PR should be closed. |
kgryte
approved these changes
Jun 7, 2024
Member
kgryte
left a comment
There was a problem hiding this comment.
LGTM. Thanks for working on this @gunjjoshi. I'll merge once CI passes.
aman-095
pushed a commit
to aman-095/stdlib
that referenced
this pull request
Jun 13, 2024
PR-URL: stdlib-js#2298 Closes: stdlib-js#894 Closes: stdlib-js#968 Ref: stdlib-js#649 Co-authored-by: Athan Reines <kgryte@gmail.com> Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Reviewed-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Athan Reines <kgryte@gmail.com>
1 task
kgryte
added a commit
that referenced
this pull request
Jul 17, 2024
1 task
1 task
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #894.
Description
This pull request:
math/base/special/spence.Related Issues
This pull request:
@stdlib/math/base/special/spence#894Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers