Skip to content

feat: add @stdlib/assert/is-nonpositive-finite#1396

Merged
Planeshifter merged 4 commits into
stdlib-js:developfrom
shubhexists:develop
Feb 27, 2024
Merged

feat: add @stdlib/assert/is-nonpositive-finite#1396
Planeshifter merged 4 commits into
stdlib-js:developfrom
shubhexists:develop

Conversation

@shubhexists
Copy link
Copy Markdown
Contributor

@shubhexists shubhexists commented Feb 26, 2024 •
edited
Loading

Resolves #1343

Description

What is the purpose of this pull request?

This pull request:

  • Add support for checking Non Positive Finite Integers

Related Issues

Does this pull request have any related issues?

#1343

This pull request:

  • resolves #
  • fixes #

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Tests
Screenshot from 2024-02-27 04-37-32
Screenshot from 2024-02-27 04-37-29

Benchmarks
Screenshot from 2024-02-27 04-38-04

Examples
Screenshot from 2024-02-27 04-38-30

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

stdlib-bot
stdlib-bot reviewed Feb 26, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Planeshifter
Planeshifter approved these changes Feb 27, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Fixed a bunch of small code style issues, but otherwise this should be ready to land. Will merge once CI has passed.

Comment thread lib/node_modules/@stdlib/assert/is-nonpositive-finite/README.md Outdated
Comment thread lib/node_modules/@stdlib/assert/is-nonpositive-finite/README.md Outdated
Comment thread lib/node_modules/@stdlib/assert/is-nonpositive-finite/examples/index.js Outdated
Comment thread lib/node_modules/@stdlib/assert/is-nonpositive-finite/docs/types/test.ts Outdated
Comment thread lib/node_modules/@stdlib/assert/is-nonpositive-finite/docs/types/test.ts
Comment thread lib/node_modules/@stdlib/assert/is-nonpositive-finite/lib/object.js Outdated
Comment thread lib/node_modules/@stdlib/assert/is-nonpositive-finite/lib/object.js Outdated
Comment thread lib/node_modules/@stdlib/assert/is-nonpositive-finite/lib/primitive.js Outdated
Comment thread lib/node_modules/@stdlib/assert/is-nonpositive-finite/lib/primitive.js Outdated
Comment thread lib/node_modules/@stdlib/assert/is-nonpositive-finite/lib/primitive.js Outdated
@Planeshifter
Apply suggestions from code review
b247738 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter Planeshifter merged commit f36bef4 into stdlib-js:develop Feb 27, 2024
@shubhexists
Copy link
Copy Markdown
Contributor Author

shubhexists commented Feb 27, 2024

Thank you sir for the suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stdlib-bot stdlib-bot stdlib-bot left review comments

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: add @stdlib/assert/is-nonpositive-finite

3 participants

@shubhexists @Planeshifter @stdlib-bot