chore: clean-up#13626
Merged
Merged
Conversation
Declaring `mlim` as an `int` overflows for `n >= 65536`, as `n*(n+1)/2` exceeds `INT_MAX`, diverging from the JavaScript implementation which computes the limit in double-precision. Also adds a missing `.h` extension to an include statement in the README C API example. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ErZxMF18HhuGHiv1ZKWR19
Corrects "shpae" to "shape" and adds a missing space in the README description of `stdlib_base_dists_beta_cdf`. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ErZxMF18HhuGHiv1ZKWR19
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Planeshifter
marked this pull request as ready for review
July 23, 2026 15:26
kgryte
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetweenfa5ac3e85(2026-07-22, 21:49 UTC) andcd1b1aa16(2026-07-23, 06:04 UTC).This pull request:
stats/base/dists/signrank/cdf:mlimwasintinlib/node_modules/@stdlib/stats/base/dists/signrank/cdf/src/main.c(a82a225), assignedn*(n+1)/2in double precision — overflowsINT_MAXforn >= 65536, UB on conversion, and diverges fromlib/main.js's double-precision limit. Fixed by declaringmlimasdoubleto match the JS implementation.stats/base/dists/signrank/cdf: inlib/node_modules/@stdlib/stats/base/dists/signrank/cdf/README.md(a82a225), the C API example includesstdlib/math/base/special/ceilwithout the.hextension, so it won't compile as written;examples/c/example.cin the same commit has it right. Add the extension to match.stats/base/dists/beta/cdf: fix typo instats/base/dists/beta/cdfREADME introduced in fa5ac3e: "shpae" → "shape" and missing space afteralphain the C API description (lib/node_modules/@stdlib/stats/base/dists/beta/cdf/README.md).Related Issues
No.
Questions
No.
Other
Review window. All nine commits merged to
developin the 24 hours preceding 2026-07-23 were reviewed: four new distribution packages (stats/base/dists/anglit/skewness,stats/base/dists/burr-type3/cdf,stats/base/dists/wald/cdf,stats/base/dists/log-logistic/variance), four C implementation backfills (stats/base/dists/binomial/cdf,stats/base/dists/signrank/cdf,stats/base/dists/hypergeometric/kurtosis,stats/base/dists/beta/cdf), and one git-notes docs commit (bd358c9).Validation. Checked: style-guide compliance (
docs/style-guides/javascript,docs/style-guides/c) against reference packages (stats/base/dists/normal/cdfand siblings); formula correctness of each implementation against the named distribution (verified algebraically, including theerfcx-based overflow avoidance inwald/cdf); C-vs-JS parity for each C port; N-API arity macros andmanifest.jsondependencies; README/repl/TypeScript docs for copy-paste errors. Deliberately excluded: subjective style preferences, anything requiring interpretation or changes outside the reviewed diffs (e.g., the small-Ndenominator behavior inhypergeometric/kurtosismatches the pre-existing JS implementation and was left as deliberate parity). No other high-signal issues were found.Note. This is a draft for maintainer audit; not requesting review.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was produced by a scheduled automated commit-review run using Claude Code: multiple review agents audited the last 24 hours of commits merged to
developfor bugs and style-guide violations, and the surviving high-signal fixes were applied and committed by Claude Code.Generated by Claude Code