feat: add @stdlib/math/base/special/sinhf#13611
Open
ujjwalv01 wants to merge 1 commit into
Open
Conversation
ujjwalv01
force-pushed
the
feat-add-sinhf
branch
from
July 22, 2026 15:58
daddb88 to
4705c20
Compare
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
ujjwalv01
force-pushed
the
feat-add-sinhf
branch
from
July 22, 2026 16:07
4705c20 to
cf07552
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #649.
Description
This pull request:
@stdlib/math/base/special/sinhfpackage, which computes the hyperbolic sine of a single-precision floating-point number.addon.c,main.c), Type definitions, Benchmarks, and Tests.src/main.c) by following the established pattern used incosm1fto wrap the double-precisionstdlib_base_sinh( x )and cast the output to afloat. I added aTODOcomment noting that this should be replaced with a specific single-precision implementation in the future.Related Issues
This pull request has the following related issues:
Questions
Since the C implementation currently wraps the double-precision
sinh, would you prefer I immediately follow up with a dedicated single-precision algorithm forsinhfin C in a future PR, or is this wrapper sufficient for the time being?Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
I consulted an AI assistant to help me research and understand the
stdlibnative package structure, specifically how to navigate C addons, bindings, and directory requirements by studying existing packages likecosm1fandsinh.@stdlib-js/reviewers