fix: correct copy-paste keyword leftovers in blas/ext/base/{sxsy,dxsy,zxsy}#13058
Draft
Planeshifter wants to merge 3 commits into
Draft
fix: correct copy-paste keyword leftovers in blas/ext/base/{sxsy,dxsy,zxsy}#13058Planeshifter wants to merge 3 commits into
blas/ext/base/{sxsy,dxsy,zxsy}#13058Planeshifter wants to merge 3 commits into
Conversation
Replace stale `add` keyword (copied from an axpy-style sibling) with `subtract` to match the package's semantics (y = x - y) and the keyword convention used in `cxsy`, `gxsy`, and `zxsy`. Ref: c7a7bd4
Replace stale `add` keyword (copied from an axpy-style sibling) with `subtract` to match the package's semantics (y = x - y) and the keyword convention used in `cxsy`, `gxsy`, and `zxsy`. Ref: 096398f
Replace stale `single` keyword (carried over from the single-precision `cxsy` sibling) with `double`. `zxsy` is the double-precision complex variant; surrounding `complex128`/`float64` keywords already tag it correctly. Ref: 2a40396
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetween 2026-06-21 13:49 UTC-7 and 2026-06-22 01:52 UTC-7 (56 commits, rangee6e7d42b..e0d79b3e).This pull request:
addkeyword copied from an axpy-style sibling inlib/node_modules/@stdlib/blas/ext/base/sxsy/package.json(c7a7bd4);sxsyimplementsy = x - y, so replaced withsubtractto align withcxsy,gxsy, andzxsy.add→subtractkeyword fix inlib/node_modules/@stdlib/blas/ext/base/dxsy/package.json(096398f);dxsyis the double-precision counterpart of the same operation.singlekeyword inlib/node_modules/@stdlib/blas/ext/base/zxsy/package.json(2a40396), copied verbatim from the single-precisioncxsysibling. Replaced withdoubleto match the double-precision complex semantics; sits alongside the existingcomplex128/float64tags.Related Issues
None.
Questions
No.
Other
Audit scope: the 56 first-parent commits to
developin the 24h window (rangee6e7d42b..e0d79b3e). Four reviewer agents (two style, two bug) ran in parallel against the union diff and per-package files, cross-checking against sibling packages of similar complexity. Findings were de-duplicated and filtered to high-signal only — objective bugs and unambiguous copy-paste typos in package metadata. Findings that matched pre-existing patterns in sibling packages (e.g.lib/index.jsshape in the*-sortedfamily) were intentionally dropped to avoid expanding scope beyond the diff window. A local report with the full audit trail (validated issues, dropped candidates and rationale, PR URL) lives at~/drift-reports/commit-review-2026-06-22.md.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running as a scheduled commit-review routine: four reviewer agents audited the last 24h of commits to
develop, findings were filtered for high-signal items, and Philipp validated and applied the resulting one-linepackage.jsonkeyword corrections.@stdlib-js/reviewers
Generated by Claude Code