chore: propagate Uint64.from and decimal-literal fixes to siblings#12954
Draft
Planeshifter wants to merge 2 commits into
Draft
chore: propagate Uint64.from and decimal-literal fixes to siblings#12954Planeshifter wants to merge 2 commits into
Uint64.from and decimal-literal fixes to siblings#12954Planeshifter wants to merge 2 commits into
Conversation
Propagates fix from 46fd304 ("chore: follow-up fixes for recent commits") to the sibling `test.assign.js` test file. `Uint64.from` is a static factory method (registered via `setReadOnly( Uint64, 'from', ... )`); calling it with `new` is incorrect API usage and parallels the `new Uint64.of` → `Uint64.of` correction landed for `README.md` and `examples/index.js` in the same package.
Propagates fix from b8c28ee ("style: add missing decimal") to the JSDoc `@example` in `stats/base/dists/negative-binomial/variance/src/main.c`. The `r` parameter is declared `const double`, so its literal argument should be written as `10.0` rather than `10` to match the dominant style across sibling distribution C source files (`mean`, `kurtosis`, `skewness`, etc.).
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Propagating fixes merged to
developbetween46fd304d(2026-06-17 21:42 UTC) andd51b3653(2026-06-18 10:46 UTC) to sibling packages.Fixes by pattern
Fixes erroneous
newkeyword usage when calling the static factory methodUint64.from, following46fd304("chore: follow-up fixes for recent commits") which removednewfromUint64.of(...)calls in the README and example for the same package.Uint64.fromis registered viasetReadOnly( Uint64, 'from', ... )and must be invoked withoutnew. Updatesnumber/uint64/base/to-words(two parallel test blocks intest/test.assign.js).Fixes a style inconsistency identified in
b8c28ee("style: add missing decimal"): C@exampleblocks must use decimal-point literals fordoubleparameters. Updatesstats/base/dists/negative-binomial/varianceto writeras10.0instead of10, matching the declaredconst doublesignature and the pattern established across all siblingnegative-binomialpackages (mean,kurtosis,skewness,stdev,mode).Related Issues
No.
Questions
No.
Other
Validation
new TYPED.METHOD(literal across all oflib/node_modules/@stdlib/, whereTYPEDis any typed-numeric ctor (Uint8,Uint16, ...,Uint64,Int8, ...,Int64,Float32,Float64,Complex64,Complex128,Bool) andMETHODisoforfrom; (b) bare integer literals passed where the corresponding parameter is declareddouble/floatin JSDoc@exampleblocks acrosslib/node_modules/@stdlib/stats/base/dists/*/src/main.c.confirmed/approvedon every pass.Uint64.fromis asetReadOnly-registered static factory matching theUint64.ofsource pattern.rarguments across all siblingnegative-binomialC source files.Deliberately excluded:
'%s::ndarray:(double colon) inutils/map*,utils/reduce*, andndarray/base/*benchmark files. The::is the intentional category separator in those packages (parallel to'%s::array:...'), distinguishing API-variant scenarios within a single benchmark file. The source fix in5d56e47corrected a copy-paste inblas/ext/base/g*benchmarks, where each API variant lives in its own file and the separator should be:— not the same defect.@exampleinteger-literal arguments understats/base/dists/*/src/main.cwhere the corresponding parameter is an integer type (int32_t), notdouble— correct usage.Checklist
AI Assistance
Yes
No
Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding
Disclosure
This PR was generated by a scheduled fix-propagation routine: enumerate fix-shaped commits merged to
developin the last 24 hours, specify each commit's defect into a grep-able pattern, search for sibling sites with the same defect, validate each candidate with two independent verification passes plus a style-consistency pass, then apply the equivalent fix. Each per-pattern commit groups all sites that share the same source pattern. Only sites confirmed by every validator advanced.@stdlib-js/reviewers