feat: add lapack/base/dlaqsp#12950
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: passed
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
Coverage Report
The above coverage report was generated for the changes in this PR. |
There was a problem hiding this comment.
| return 'N'; |
Early return and save yourself indentation. You can remove the next else block.
There was a problem hiding this comment.
| return 'Y'; |
No need for the equed variable.
There was a problem hiding this comment.
Returning a string is an odd choice, at least in JavaScript. I realize that this is what Fortran does. And there is an argument to be consistent at the C layer. But returning a string here is unconventional in JS-land.
There are other possibilities. For example, we could return a boolean with true being success and false being failure. We could also return a "status" integer, with 0 being success and non-zero being failure. IIRC, other LAPACK routines use a status integer to indicate error modes. I am wondering if we should be consistent here.
I'd be curious to hear your thoughts here.
There was a problem hiding this comment.
Are there other LAPACK routines which return strings like this?
There was a problem hiding this comment.
...just curious how common an occurrence this may be. If it is a one-off, we could potentially choose to deviate. If it is relatively common, then we should be more intentional in our approach.
There was a problem hiding this comment.
Your equation belongs in the introduction, not inlined here in the function description.
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves none.
Description
This pull request:
Related Issues
This pull request has the following related issues:
lapack/base/dlaqspQuestions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers