fix: correct style deviations and Markdown lint variable references#12155
Draft
Planeshifter wants to merge 3 commits into
Draft
fix: correct style deviations and Markdown lint variable references#12155Planeshifter wants to merge 3 commits into
Planeshifter wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
developbetween 2026-05-15 13:29 PDT and 2026-05-16 00:22 PDT (SHA range822b65687^..bfb2f6e19, 10 commits).blas/ext/base/ndarray/zindex-of(complex128) andblas/ext/base/ndarray/cindex-of(complex64) — plus namespace wiring, a dispatch-table update inblas/ext/index-of, scoped Markdown lint tooling, and bot-generated docs updates. The fixes below address style deviations in the two new packages and one build-tooling bug in the new Markdown lint rules.Fixes, grouped by package:
blas/ext/base/ndarray/zindex-ofexamples/index.jsand the## Examplesblock ofREADME.md(commit822b65687): both imported@stdlib/ndarray/ndarraylike2scalarinstead of@stdlib/ndarray/base/ndarraylike2scalar, diverging fromlib/main.jsand the siblingdindex-of,sindex-of, andgindex-ofpackages, which all use the base package.822b65687introduced the package with four spurious dtype-specific keywords (complex128,complex,double-precision,float64) inpackage.jsonthat no sibling package (dindex-of,sindex-of,gindex-of,zsum,csum) carries; removed them so thekeywordsarray terminates atndarray, consistent with family convention.blas/ext/base/ndarray/cindex-ofexamples/index.jsand the## Examplesblock ofREADME.md(commitca72b065a): both imported the higher-level@stdlib/ndarray/ndarraylike2scalarwrapper instead of@stdlib/ndarray/base/ndarraylike2scalar, which is whatlib/main.jsand every sibling package (dindex-of,sindex-of,gindex-of) use.ca72b065aintroduced the package with four spurious dtype-specific keywords (complex64,complex,single-precision,float32) inpackage.jsonthat no sibling package (dindex-of,sindex-of,gindex-of,zsum,csum) carries; removed them so thekeywordsarray terminates atndarray, consistent with family convention.tools/make/lib/lint/markdownec3ccdf7bintools/make/lib/lint/markdown/Makefile: the four new lint rules referencedMARKDOWN_LINT_PKG_READMES_FLAGSandMARKDOWN_LINT_DOCS_FLAGS, butremark.mkdefines those variables asMARKDOWN_LINT_FLAGS_PKG_READMESandMARKDOWN_LINT_FLAGS_DOCS. The wrong names expanded to empty, soremarkran without--rc-pathand the scoped.remarkrc.pkg_readmes.js/.remarkrc.docs.jsconfigs were never applied. Renamed all eight references to match the definitions inremark.mk.Related Issues
None.
Questions
No.
Other
Validation. Each commit in the window was reviewed for typos, bugs, and stdlib style-guide compliance. Checks performed:
dindex-of,sindex-of, andgindex-of(and the complex analogszsum/csum).Each fix above was independently re-verified before inclusion. Deliberately excluded (require interpretation, not objective defects):
@stdlib/random/array/discrete-uniform/@stdlib/random/array/uniformrather than the ndarray-returning forms used by the real-valued reference packages. The array-returning form wrapped in a complex vector is the legitimate pattern for complex-typed packages, so this is intentional, not a defect.// VARIABLES //section present in the reference benchmarks. The new benchmarks have no module-level variables; adding the section would be a structural refactor rather than a defect fix.bfb2f6e19,66ec9de8d) and the git-notes commit (8995b6e57) are documentation/text only and were left untouched.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code. It reviewed the commits merged to
developover the preceding 24 hours, identified style deviations and one build-tooling bug, and applied the fixes. Every finding was verified against existing reference packages and the affected files before inclusion.@stdlib-js/reviewers
Generated by Claude Code