refactor: use constants/float64/nan in math/base/special/fibonacci#12154
refactor: use constants/float64/nan in math/base/special/fibonacci#12154puneetdixit200 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
Resolves a part of #11743
Description
This pull request:
0.0 / 0.0NaN generation inmath/base/special/fibonacciwithSTDLIB_CONSTANT_FLOAT64_NAN.@stdlib/constants/float64/nanas a manifest dependency for build, benchmark, and examples tasks.Related Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Verification
make install-node-addons NODE_ADDONS_PATTERN='math/base/special/fibonacci'make EXAMPLES_FILTER='.*/math/base/special/fibonacci/.*' examples-cmake BENCHMARKS_FILTER='.*/math/base/special/fibonacci/.*' benchmark-cmake test TESTS_FILTER='.*/math/base/special/fibonacci/.*'All package-specific checks passed.
Checklist
AI Assistance
This PR was prepared with Codex assistance.