Skip to content

refactor: use constants/float64/nan in math/base/special/fibonacci#12154

Open
puneetdixit200 wants to merge 1 commit into
stdlib-js:developfrom
puneetdixit200:refactor-fibonacci-nan
Open

refactor: use constants/float64/nan in math/base/special/fibonacci#12154
puneetdixit200 wants to merge 1 commit into
stdlib-js:developfrom
puneetdixit200:refactor-fibonacci-nan

Conversation

@puneetdixit200
Copy link
Copy Markdown

@puneetdixit200 puneetdixit200 commented May 16, 2026

Resolves a part of #11743

Description

This pull request:

  • Replaces inline 0.0 / 0.0 NaN generation in math/base/special/fibonacci with STDLIB_CONSTANT_FLOAT64_NAN.
  • Adds @stdlib/constants/float64/nan as a manifest dependency for build, benchmark, and examples tasks.

Related Issues

This pull request has the following related issues:

  • No.

Questions

No.

Other

No.

Verification

  • make install-node-addons NODE_ADDONS_PATTERN='math/base/special/fibonacci'
  • make EXAMPLES_FILTER='.*/math/base/special/fibonacci/.*' examples-c
  • make BENCHMARKS_FILTER='.*/math/base/special/fibonacci/.*' benchmark-c
  • make test TESTS_FILTER='.*/math/base/special/fibonacci/.*'

All package-specific checks passed.

Checklist

AI Assistance

  • Yes
  • No

This PR was prepared with Codex assistance.

@puneetdixit200 puneetdixit200 requested review from a team and Copilot May 16, 2026 12:08
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. labels May 16, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. labels May 16, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants