Skip to content

chore: add Git notes for broken commit messages#12080

Open
Planeshifter wants to merge 2 commits into
developfrom
philipp/fix-git-notes-blas-stats
Open

chore: add Git notes for broken commit messages#12080
Planeshifter wants to merge 2 commits into
developfrom
philipp/fix-git-notes-blas-stats

Conversation

@Planeshifter
Copy link
Copy Markdown
Member

@Planeshifter Planeshifter commented May 10, 2026

Resolves stdlib-js/todo#2762.

Description

What is the purpose of this pull request?

This pull request:

  • adds Git notes (amend-message) for five commits whose subjects referenced blas/base packages instead of the actual stats/base packages that were modified:
    • 4ac66ae1c4bb0fced3efc36152899723c3ebf4dc → stats/base/snanstdevtk
    • 7804aaa23131173d59d96417301c981129c248d7 → stats/base/snanstdevpn (also fixes snanstdevchpn typo; the touched file is stats/base/snanstdevpn)
    • bf9d681bb656cb9356a7480a63e306353d52464a → stats/base/snanstdevch
    • 483f9f50458690009bdfe4266ce6dc95eebb9c24 → stats/base/snanstdev
    • 52a160e49ca32d8041b88604de65b47935b521fa → stats/base/sdsnanmean

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • stdlib-js/todo#2762

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written by Claude Code.

@stdlib-js/reviewers

@Planeshifter
chore: add Git note
2c4d1b6 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Planeshifter
chore: add Git notes
7596e6d 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Planeshifter Planeshifter marked this pull request as ready for review May 10, 2026 21:46
@Planeshifter Planeshifter requested review from a team and kgryte May 10, 2026 21:46
kgryte
kgryte reviewed May 10, 2026
View reviewed changes
Comment thread docs/git-notes/db9343fab98f282507251bac9547c713d5811cd7.txt
Copy link
Copy Markdown
Member

@kgryte kgryte May 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Planeshifter Did you mean to include this Git note along with the others above?

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label May 10, 2026
@kgryte kgryte added Needs Discussion Needs further discussion. and removed Needs Review A pull request which needs code review. labels May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Needs Discussion Needs further discussion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Planeshifter @kgryte @stdlib-bot