Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: done some changes
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
  • Loading branch information
Sachinn-64 committed Apr 8, 2026
commit 58f1633021e0a879296ff72a352954f67c1c103a
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,7 @@ function defaults() {
'angle': 0,

// Symbol shape:
'shape': 'circle',

// Area of the symbol in pixels squared:
'size': 0
'shape': 'circle'
};
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@
/**
* Symbol mark constructor.
*
* @module @stdlib/plot/vega/mark/symbol/ctor
* @module @stdlib/plot/vega/mark/symbol
*
* @example
* var SymbolMark = require( '@stdlib/plot/vega/mark/symbol/ctor' );
* var SymbolMark = require( '@stdlib/plot/vega/mark/symbol' );
*
* var mark = new SymbolMark({
* 'shape': 'square'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,9 @@
if ( hasProp( options, 'type' ) && options.type !== TYPE ) {
throw new TypeError( format( 'invalid argument. `%s` option must be equal to "%s". Option: `%s`.', 'type', TYPE, options.type ) );
}
// Inject the mark type into the options before calling the parent constructor:
options.type = TYPE;
Mark.call( this, options );
this._type = TYPE;

// Resolve the default configuration:
opts = defaults();
Expand All @@ -141,11 +141,11 @@
} catch ( err ) {
debug( 'Encountered an error. Error: %s', err.message );

// FIXME: retain thrown error type

Check warning on line 144 in lib/node_modules/@stdlib/plot/vega/mark/symbol/lib/main.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files

Unexpected 'fixme' comment: 'FIXME: retain thrown error type'
throw new Error( transformErrorMessage( err.message ) );
}
}
this._type = TYPE;

return this;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
* @returns {void}
*/
function set( value ) {
// TODO: validate SVG path strings for proper formatting instead of accepting any raw string

Check warning on line 48 in lib/node_modules/@stdlib/plot/vega/mark/symbol/lib/shape/set.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files

Unexpected 'todo' comment: 'TODO: validate SVG path strings for...'
if ( !isString( value ) ) {
throw new TypeError( format( 'invalid assignment. `%s` must be a string. Value: `%s`.', prop.name, value ) );
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ var prop = require( './properties.js' );
* Returns the symbol size.
*
* @private
* @returns {number} symbol size
* @returns {void|number} symbol size
*/
function get() {
return this[ prop.private ];
Expand Down
Comment thread
Sachinn-64 marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ var debug = logger( 'vega:symbol-mark:set:'+prop.name );
* Sets the symbol size.
*
* @private
* @param {NonNegativeNumber} value - input value
* @param {void|NonNegativeNumber} value - input value
* @throws {TypeError} must be a nonnegative number
* @returns {void}
*/
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "@stdlib/plot/vega/mark/symbol/ctor",
"name": "@stdlib/plot/vega/mark/symbol",
"version": "0.0.0",
"description": "Symbol mark constructor.",
"license": "Apache-2.0",
Expand Down
Loading