Skip to content

Fully parse function names with @ in Error.stack #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eriwen merged 1 commit into from
Jan 3, 2016
Merged

Fully parse function names with @ in Error.stack #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion error-stack-parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@
} else {
var tokens = line.split('@');
var locationParts = this.extractLocation(tokens.pop());
var functionName = tokens.shift() || undefined;
var functionName = tokens.join('@') || undefined;
return new StackFrame(functionName, undefined, locationParts[0], locationParts[1], locationParts[2], line);
}
}, this);
Expand Down
8 changes: 8 additions & 0 deletions spec/error-stack-parser-spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,14 @@ describe('ErrorStackParser', function () {
expect(stackFrames[4]).toMatchStackFrame([undefined, undefined, 'http://localhost:8080/file.js', 33, 9]);
});

it('should parse function names containing @ in Firefox 43 Error.stack', function () {
var stackFrames = unit.parse(CapturedExceptions.FIREFOX_43_FUNCTION_NAME_WITH_AT_SIGN);
expect(stackFrames).toBeTruthy();
expect(stackFrames.length).toBe(2);
expect(stackFrames[0]).toMatchStackFrame(['obj["@fn"]', undefined, 'Scratchpad/1', 10, 29]);
expect(stackFrames[1]).toMatchStackFrame([undefined, undefined, 'Scratchpad/1', 11, 1]);
});

it('should parse V8 Error.stack', function () {
var stackFrames = unit.parse(CapturedExceptions.CHROME_15);
expect(stackFrames).toBeTruthy();
Expand Down
11 changes: 11 additions & 0 deletions spec/fixtures/captured-errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,17 @@ CapturedExceptions.FIREFOX_43_NESTED_EVAL = {
"@http://localhost:8080/file.js:33:9"
};

CapturedExceptions.FIREFOX_43_FUNCTION_NAME_WITH_AT_SIGN = {
message: "Dummy error",
name: "Error",
stack: 'obj["@fn"]@Scratchpad/1:10:29\n' +
"@Scratchpad/1:11:1\n" +
"",
fileName: "Scratchpad/1",
lineNumber: 10,
columnNumber: 29
};

CapturedExceptions.SAFARI_6 = {
message: "'null' is not an object (evaluating 'x.undef')",
stack: "@http://path/to/file.js:48\n" +
Expand Down