Skip to content

fix(deps): update compress for CVE-2026-116591 (5.0) - #23826

Open
dashrews78 wants to merge 1 commit into
release-5.0from
dashrews/fix-cve-2026-116591-release-5.0
Open

dashrews78 wants to merge 1 commit into
release-5.0from
dashrews/fix-cve-2026-116591-release-5.0

Conversation

@dashrews78

Copy link
Copy Markdown
Collaborator

Description

Backport the compress v1.20.3 update from #23464 to release-5.0 to include the CVE-2026-116591 zstd decoder fix. Updating the shared root dependency covers the binaries built from this module; legacy Scanner is updated separately in stackrox/scanner.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

  • go list -m github.com/klauspost/compress: v1.20.3.
  • Upstream TestDecoderHuffWeightsTableLog passes (covers the CVE input in DecodeAll and streaming modes).
  • Targeted Scanner V4 compression-reader and vulnerability-bundle tests pass.
  • git diff --check passes.
  • Full make style was attempted but local validation is incomplete; CI review remains pending.

Dependency-only change; existing regression and application tests were reused.

Backport the v1.20.3 dependency update already merged in #23464.
This includes the upstream zstd two-block panic fix without application changes.

User request: "Create all the necessary PRs in stackrox and scanner."

This change was partially generated by AI.
@dashrews78 dashrews78 added dependencies Pull requests that update a dependency file ci-all-qa-tests Tells CI to run all API tests (not just BAT). ai-assisted labels Nov 2, 2026
@openshift-ci

openshift-ci Bot commented Nov 2, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions github-actions Bot added the backport PR to backport changes from master to release branch label Nov 2, 2026
@dashrews78
dashrews78 marked this pull request as ready for review November 2, 2026 18:51
@dashrews78
dashrews78 requested a review from a team as a code owner November 2, 2026 18:51
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Build Images Ready

Images are ready for commit 592a9d1. To use with deploy scripts:

export MAIN_IMAGE_TAG=5.0.0-rc.5-1-g592a9d15d4

@codecov

codecov Bot commented Nov 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.89%. Comparing base (685e397) to head (592a9d1).

Additional details and impacted files
@@               Coverage Diff               @@
##           release-5.0   #23826      +/-   ##
===============================================
- Coverage        51.93%   51.89%   -0.05%     
===============================================
  Files             2905     2905              
  Lines           182946   182946              
===============================================
- Hits             95017    94941      -76     
- Misses           79628    79683      +55     
- Partials          8301     8322      +21     
Flag Coverage Δ
go-unit-tests 51.89% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

/konflux-retest scanner-v4-on-push

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

/konflux-retest operator-on-push

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

/konflux-retest roxctl-on-push

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

/konflux-retest scanner-v4-on-push

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

/konflux-retest operator-on-push

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

/konflux-retest roxctl-on-push

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

/konflux-retest scanner-v4-on-push

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

/konflux-retest operator-on-push

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

/konflux-retest roxctl-on-push

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

/konflux-retest operator-bundle-on-push

2 similar comments
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

/konflux-retest operator-bundle-on-push

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

/konflux-retest operator-bundle-on-push

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

/konflux-retest operator-index-on-push

1 similar comment
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

/konflux-retest operator-index-on-push

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

/konflux-retest create-custom-snapshot

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

/konflux-retest operator-index-on-push

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

/konflux-retest create-custom-snapshot

1 similar comment
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

/konflux-retest create-custom-snapshot

@dashrews78

Copy link
Copy Markdown
Collaborator Author

/retest

1 similar comment
@dashrews78

Copy link
Copy Markdown
Collaborator Author

/retest

@dashrews78

Copy link
Copy Markdown
Collaborator Author

CI failure triage (2026-11-03)

None of the current failures are caused by the compress bump.

GHA e2e failures (gke-upgrade-tests ×3, db-backup-restore, nongroovy)

All five jobs die in the "Verify kubectl access and wait for cluster to stabilize" step, before deploying anything:

gcloud crashed (AttributeError): 'Credentials' object has no attribute 'private_key_id'
Unable to connect to the server: getting credentials: exec: executable gke-gcloud-auth-plugin failed with exit code 1

Known issue: google-github-actions/auth#535 — CLOUDSDK_AUTH_CREDENTIAL_FILE_OVERRIDE pointing at the action's gha-creds-*.json crashes newer gcloud.

Once #23792 merges, these jobs should go green on re-run. No action needed here.

Konflux acs-conforma-dev-5-0 failures

TL;DR: re-run e2e after #23792 lands; conforma failures are branch-wide noise.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-assisted backport PR to backport changes from master to release branch ci-all-qa-tests Tells CI to run all API tests (not just BAT). dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant