Skip to content

fix(deps): update compress for CVE-2026-116591 (4.10) - #23824

Open
dashrews78 wants to merge 1 commit into
release-4.10from
dashrews/fix-cve-2026-116591-release-4.10
Open

dashrews78 wants to merge 1 commit into
release-4.10from
dashrews/fix-cve-2026-116591-release-4.10

Conversation

@dashrews78

Copy link
Copy Markdown
Collaborator

Description

Backport the compress v1.20.3 update from #23464 to release-4.10 to include the CVE-2026-116591 zstd decoder fix. Updating the shared root dependency covers the binaries built from this module; legacy Scanner is updated separately in stackrox/scanner.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

  • go list -m github.com/klauspost/compress: v1.20.3.
  • Upstream TestDecoderHuffWeightsTableLog passes (covers the CVE input in DecodeAll and streaming modes).
  • Targeted Scanner V4 compression-reader and vulnerability-bundle tests pass.
  • git diff --check passes.
  • Full make style was attempted but local validation is incomplete; CI review remains pending.

Dependency-only change; existing regression and application tests were reused.

Backport the v1.20.3 dependency update already merged in #23464.
This includes the upstream zstd two-block panic fix without application changes.

User request: "Create all the necessary PRs in stackrox and scanner."

This change was partially generated by AI.
@dashrews78 dashrews78 added dependencies Pull requests that update a dependency file ci-all-qa-tests Tells CI to run all API tests (not just BAT). ai-assisted labels Nov 2, 2026
@openshift-ci

openshift-ci Bot commented Nov 2, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions github-actions Bot added the backport PR to backport changes from master to release branch label Nov 2, 2026
@dashrews78
dashrews78 marked this pull request as ready for review November 2, 2026 18:51
@dashrews78
dashrews78 requested a review from a team as a code owner November 2, 2026 18:51
@rhacs-bot

Copy link
Copy Markdown
Contributor

Images are ready for the commit at 39bb308.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.10.11-1-g39bb308279.

@codecov

codecov Bot commented Nov 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.51%. Comparing base (21a0a17) to head (39bb308).

Additional details and impacted files
@@               Coverage Diff                @@
##           release-4.10   #23824      +/-   ##
================================================
- Coverage         49.52%   49.51%   -0.01%     
================================================
  Files              2663     2663              
  Lines            201394   201394              
================================================
- Hits              99737    99727      -10     
- Misses            94202    94212      +10     
  Partials           7455     7455              
Flag Coverage Δ
go-unit-tests 49.51% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@openshift-ci

openshift-ci Bot commented Nov 2, 2026

Copy link
Copy Markdown

@dashrews78: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-qa-e2e-tests 39bb308 link false /test gke-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-assisted backport PR to backport changes from master to release branch ci-all-qa-tests Tells CI to run all API tests (not just BAT). dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants