ROX-36332: Enable WIF testing - #23818

@@            Coverage Diff             @@
##           master   #23818      +/-   ##
==========================================
- Coverage   52.61%   52.57%   -0.04%     
==========================================
  Files        2836     2836              
  Lines      177975   177975              
==========================================
- Hits        93644    93574      -70     
- Misses      76139    76186      +47     
- Partials     8192     8215      +23     

Flags with carried forward coverage won't be shown. Click here to find out more.

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Summary by CodeRabbit

• Chores
  • Enabled workload identity setup in the OpenShift FIPS QA test workflow.
  • Workload identities are now cleaned up when the test run finishes, including on script exit. Cleanup runs once when performed explicitly. This updates the QA workflow’s identity setup and cleanup behavior without changing the workflow’s end-user features.

The FIPS Konflux E2E workflow enables workload identity setup. The test script registers workload identity cleanup on shell exit and clears the trap after running cleanup explicitly.

Changes: Workload identity setup and cleanup

Layer / File(s)	Summary
Configure setup and cleanup .github/workflows/e2e-qa-tests-ocp-fips-konflux.yaml, qa-tests-backend/scripts/run-part-1.sh	The workflow adds SETUP_WORKLOAD_IDENTITIES=true and removes the related TODO and commented-out assignment. The test script registers cleanup_workload_identities as an EXIT trap, then clears the trap after explicit cleanup.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: mclasmeier

Merge Risk: Minimal · previous review c980d

No actionable merge-blocking risk is established for this workload-identity lifecycle change.

Pre-merge checks: 3 · 1 · 1

Failed checks: 1 warning · 1 inconclusive

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check		The description states the purpose in one line: "Enables Workload Identity in tests." It does not explain the changes to the workflow env vars or the cleanup trap. The template's CHANGELOG and documen…	Replace the "change me!" placeholder in the "How I validated my change" section with the validation performed, or explain why testing was skipped and when validation will happen. Add a short explanation of the changes: setting SETUP_WORKLOA…

Passed checks: 3 passed

Check name	Status	Explanation
Title check		The title "ROX-36332: Enable WIF testing" matches the change. The PR turns on workload identity setup (SETUP_WORKLOAD_IDENTITIES=true) in the OCP FIPS Konflux e2e workflow and adds a cleanup_workload_…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title "ROX-36332: Enable WIF testing" matches the change. The PR turns on workload identity setup (SETUP_WORKLOAD_IDENTITIES=true) in the OCP FIPS Konflux e2e workflow and adds a cleanup_workload_identities EXIT trap in run-part-1.sh. The title names the main change, and the ticket ID gives traceability. It is concise and specific, though it does not mention the cleanup trap.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 1 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Full details: Description check

Explanation

The description states the purpose in one line: "Enables Workload Identity in tests." It does not explain the changes to the workflow env vars or the cleanup trap. The template's CHANGELOG and documentation checkboxes are unchecked and not explained. The testing section still reads "change me!" and no validation steps are given. The template's testing and validation sections are mostly incomplete.

Resolution

Replace the "change me!" placeholder in the "How I validated my change" section with the validation performed, or explain why testing was skipped and when validation will happen. Add a short explanation of the changes: setting SETUP_WORKLOAD_IDENTITIES=true in the e2e-qa-tests-ocp-fips-konflux workflow, and registering cleanup_workload_identities as an EXIT trap in run-part-1.sh. Mark the applicable checkboxes or state why they do not apply, including the CHANGELOG and documentation items.

Generate docstrings

• Commit to this branch
• Create a new PR

Generate unit tests (beta)

• Commit to this branch
• Create a new PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.