Skip to content

fix(ci): Update test timeout - #23504

Open
iamkirkbater wants to merge 1 commit into
masterfrom
kirk/qa-e2e-violation-timeout-increase
Open

iamkirkbater wants to merge 1 commit into
masterfrom
kirk/qa-e2e-violation-timeout-increase

Conversation

@iamkirkbater

Copy link
Copy Markdown
Contributor

Description

Updates the test timeout to align with other Scanner e2e test timeouts.

This job is consistently timing out, according to Claude it's persistently hitting exponential backoffs due to the architecture. Hopefully this gives some breathing room so that this isn't a test that consistently fails.

Additionally, according to claude any refactoring to make the logic itself work would require a rearchitecture of the code itself, which is largely out of scope here.

I'm happy to put that context into a followup ticket if desired.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Validate CI runs.

@iamkirkbater
iamkirkbater requested a review from janisz as a code owner October 19, 2026 19:30
@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Central YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ae10a887-2474-4ba5-98cf-c229ee4c8f49
📥 Commits

Reviewing files that changed from the base of the PR and between 6991e75 and 90b3523.

📒 Files selected for processing: 1
  • qa-tests-backend/src/test/groovy/GlobalSearch.groovy

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Tests
    • Increased the wait time for global search test setup from 30 to 90 seconds.

The violation wait timeout in the GlobalSearch specification setup increased from 30 to 90 seconds.

Changes: GlobalSearch Timeout

Layer / File(s) Summary
Increase violation wait timeout
qa-tests-backend/src/test/groovy/GlobalSearch.groovy
The violation wait timeout used during specification setup changed from 30 to 90 seconds.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: janisz

Merge Risk: ⚪ Minimal · up to 90b35

GlobalSearch may wait up to 90 seconds instead of 30 for a violation, adding time only when it is delayed or absent. This remains within the configured test and CI limits, so no merge-blocking risk is identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the timeout change in the CI test.
Description check Passed The description explains the timeout increase, its rationale, scope, testing impact, and planned CI validation. It includes the required template sections. Several checklist items remain unchecked, bu…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the timeout increase, its rationale, scope, testing impact, and planned CI validation. It includes the required template sections. Several checklist items remain unchecked, but the description is otherwise sufficiently complete for this test-only change.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.96%. Comparing base (0ce23fd) to head (90b3523).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #23504      +/-   ##
==========================================
- Coverage   52.01%   51.96%   -0.05%     
==========================================
  Files        2914     2914              
  Lines      183753   183753              
==========================================
- Hits        95574    95496      -78     
- Misses      79835    79892      +57     
- Partials     8344     8365      +21     
Flag Coverage Δ
go-unit-tests 51.96% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Build Images Ready

Images are ready for commit 90b3523. To use with deploy scripts:

export MAIN_IMAGE_TAG=5.1.x-305-g90b3523429

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant