Skip to content

ROX-37653: Rewrite ESLint config as ECMAScript module #23503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pedrottimark wants to merge 2 commits into
base: master
Choose a base branch
from
+37 −38
Open

ROX-37653: Rewrite ESLint config as ECMAScript module #23503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f238c47
ROX-37653: Rewrite ESLint config as ECMAScript module
Oct 19, 2026
d48b862
Rename config file in allowed-large-files
Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/allowed-large-files
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ tests/e2e/run-scanner-v4-install.bats
tests/performance/load/package-lock.json
tests/performance/scale/config/metrics-acs.yml
tests/performance/scale/config/metrics-full.yml
ui/apps/platform/eslint.config.js
ui/apps/platform/eslint.config.mjs
ui/apps/platform/package-lock.json
ui/apps/platform/src/Containers/Integrations/IntegrationForm/Forms/SignatureIntegrationForm.tsx
ui/apps/platform/src/Containers/Policies/Wizard/Step3/policyCriteriaDescriptors.tsx
73 changes: 36 additions & 37 deletions ui/apps/platform/eslint.config.js → ui/apps/platform/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,43 +1,42 @@
'use strict';

const path = require('node:path');

const parserTypeScriptESLint = require('@typescript-eslint/parser');

const pluginCypress = require('eslint-plugin-cypress');
const pluginCSS = require('@eslint/css').default;
const pluginESLint = require('@eslint/js');
const pluginJSON = require('@eslint/json').default;
const pluginMarkdown = require('@eslint/markdown').default; // ECMAScript module requires Node.js 22.12.0 or later
const pluginESLintComments = require('@eslint-community/eslint-plugin-eslint-comments');
const pluginImport = require('eslint-plugin-import');
const pluginJestDOM = require('eslint-plugin-jest-dom');
const pluginPrettier = require('eslint-plugin-prettier');
const pluginReact = require('eslint-plugin-react');
const pluginReactHooks = require('eslint-plugin-react-hooks');
const pluginTestingLibrary = require('eslint-plugin-testing-library');
const pluginTypeScriptESLint = require('@typescript-eslint/eslint-plugin');
const pluginVitest = require('@vitest/eslint-plugin');

const { browser: browserGlobals, node: nodeGlobals, vitest: vitestGlobals } = require('globals');

const pluginAccessibility = require('./eslint-plugins/pluginAccessibility');
const pluginGeneric = require('./eslint-plugins/pluginGeneric');
const pluginLimited = require('./eslint-plugins/pluginLimited');
const pluginPatternFly = require('./eslint-plugins/pluginPatternFly');
import path from 'node:path';

import parserTypeScriptESLint from '@typescript-eslint/parser';

import pluginCypress from 'eslint-plugin-cypress';
import pluginCSS from '@eslint/css';
import pluginESLint from '@eslint/js';
import pluginJSON from '@eslint/json';
import pluginMarkdown from '@eslint/markdown';
import pluginESLintComments from '@eslint-community/eslint-plugin-eslint-comments';
import pluginImport from 'eslint-plugin-import';
import pluginJestDOM from 'eslint-plugin-jest-dom';
import pluginPrettier from 'eslint-plugin-prettier';
import pluginReact from 'eslint-plugin-react';
import pluginReactHooks from 'eslint-plugin-react-hooks';
import pluginTestingLibrary from 'eslint-plugin-testing-library';
import pluginTypeScriptESLint from '@typescript-eslint/eslint-plugin';
import pluginVitest from '@vitest/eslint-plugin';

import globals from 'globals';
const { browser: browserGlobals, node: nodeGlobals, vitest: vitestGlobals } = globals;

import pluginAccessibility from './eslint-plugins/pluginAccessibility.js';
import pluginGeneric from './eslint-plugins/pluginGeneric.js';
import pluginLimited from './eslint-plugins/pluginLimited.js';
import pluginPatternFly from './eslint-plugins/pluginPatternFly.js';

const parser = parserTypeScriptESLint;
const parserOptions = {
project: './tsconfig.eslint.json',
tsconfigRootDir: __dirname,
tsconfigRootDir: import.meta.dirname,
};

const parserAndOptions = {
parser,
parserOptions,
};

module.exports = [
export default [
{
// Supersede .eslintignore file.
// ESLint provides ["**/node_modules/", ".git/"] as default ignores.
Expand Down Expand Up @@ -643,7 +642,7 @@ module.exports = [
'error',
{
devDependencies: [
path.join(__dirname, 'src/test-utils/*'), // TODO delete renderWithRedux.js
path.join(import.meta.dirname, 'src/test-utils/*'), // TODO delete renderWithRedux.js
],
},
],
Expand Down Expand Up @@ -1204,12 +1203,12 @@ module.exports = [
'error',
{
devDependencies: [
path.join(__dirname, 'eslint.config.js'),
path.join(__dirname, 'postcss.config.js'),
path.join(__dirname, 'tailwind.config.js'), // only for @tailwindcss/forms
path.join(__dirname, 'webpack.ocp-plugin.config.js'),
path.join(__dirname, 'vite.config.js'),
path.join(__dirname, 'cypress.config.js'),
path.join(import.meta.dirname, 'eslint.config.js'),
path.join(import.meta.dirname, 'postcss.config.js'),
path.join(import.meta.dirname, 'tailwind.config.js'), // only for @tailwindcss/forms
path.join(import.meta.dirname, 'webpack.ocp-plugin.config.js'),
path.join(import.meta.dirname, 'vite.config.js'),
path.join(import.meta.dirname, 'cypress.config.js'),
],
},
],
Expand All @@ -1236,7 +1235,7 @@ module.exports = [
'import/no-extraneous-dependencies': [
'error',
{
devDependencies: [path.join(__dirname, 'src/**/*.test.*')],
devDependencies: [path.join(import.meta.dirname, 'src/**/*.test.*')],
},
],

Expand Down
Loading