Skip to content

chore(operator-e2e): add cert-watcher verification to kuttl tests - #23501

Merged
vladbologa merged 1 commit into
masterfrom
vb/operator-e2e-cert-watcher
Oct 20, 2026
Merged

chore(operator-e2e): add cert-watcher verification to kuttl tests#23501
vladbologa merged 1 commit into
masterfrom
vb/operator-e2e-cert-watcher

Conversation

@vladbologa

@vladbologa vladbologa commented Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR adds an extra verification step to the operator-e2e test that checks if cert-watcher sidecars started correctly in central-db and scanner-v4-db deployments. This was previously only covered in the scanner-v4-install test suite, in the [Operator] Fresh installation with Scanner V4 enabled test.

Why I'm making this change:

  • the scanner-v4-install test case might be removed in the future
  • the operator-e2e test would have been the better place for this check in the first place

Follow-up to #20335 (ROX-29509)

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Verified in the CI logs that the checks actually execute:

step.go:469: 16:39:48 | central-basic/11-verify-cert-watchers | starting test step 11-verify-cert-watchers
commands.go:113: 16:39:48 | central-basic/11-verify-cert-watchers | running command: [sh -c verify-cert-watcher.sh central-db scanner-v4-db]
logger.go:68: 16:39:48 | central-basic/11-verify-cert-watchers | Verifying cert-watcher sidecar is running in kuttl-concrete-giraffe-vtk4/central-db...
logger.go:68: 16:39:49 | central-basic/11-verify-cert-watchers | cert-watcher is running in kuttl-concrete-giraffe-vtk4/central-db
logger.go:68: 16:39:49 | central-basic/11-verify-cert-watchers | Verifying cert-watcher sidecar is running in kuttl-concrete-giraffe-vtk4/scanner-v4-db...
logger.go:68: 16:39:49 | central-basic/11-verify-cert-watchers | cert-watcher is running in kuttl-concrete-giraffe-vtk4/scanner-v4-db
step.go:513: 16:39:49 | central-basic/11-verify-cert-watchers | test step completed 11-verify-cert-watchers

@vladbologa
vladbologa requested a review from a team as a code owner October 19, 2026 14:40
@vladbologa
vladbologa requested review from GrimmiMeloni and removed request for a team October 19, 2026 14:40
@codecov

codecov Bot commented Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.96%. Comparing base (818f2c4) to head (763dcf7).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #23501      +/-   ##
==========================================
- Coverage   52.00%   51.96%   -0.05%     
==========================================
  Files        2914     2914              
  Lines      183753   183753              
==========================================
- Hits        95567    95488      -79     
- Misses      79840    79896      +56     
- Partials     8346     8369      +23
Flag Coverage Δ
go-unit-tests 51.96% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🚀 Build Images Ready

Images are ready for commit 0ace3de. To use with deploy scripts:

export MAIN_IMAGE_TAG=5.1.x-314-g0ace3dea2c

@vladbologa vladbologa changed the title chore(operator-e2e): add cert-watcher sidecar verification to kuttl tests chore(operator-e2e): add cert-watcher verification to kuttl tests Oct 19, 2026
@vladbologa
vladbologa force-pushed the vb/operator-e2e-cert-watcher branch from a7d91cc to 763dcf7 Compare October 19, 2026 15:03
@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Central YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 360e7cbf-9aa0-4a0c-a3c8-0643158c0ee3
📥 Commits

Reviewing files that changed from the base of the PR and between 818f2c4 and 763dcf7.

📒 Files selected for processing: 2
  • operator/hack/verify-cert-watcher.sh
  • operator/tests/central/central-basic/011-verify-cert-watchers.yaml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Tests
    • Added a deployment check that verifies certificate watchers are running for the central database and scanner database.

The pull request adds a script that checks cert-watcher logs for specified deployments. A KUTTL test step runs the script for central-db and scanner-v4-db.

Changes: Cert watcher verification

Layer / File(s) Summary
Verify cert watcher logs
operator/hack/verify-cert-watcher.sh, operator/tests/central/central-basic/011-verify-cert-watchers.yaml		 The script checks required inputs, polls each deployment’s logs for cert-watcher: watching, and returns a failure status if any deployment does not pass. The KUTTL test step runs the script for central-db and scanner-v4-db.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 763dc

The change adds cert-watcher startup checks for both database deployments. The test setup provides the required namespace and establishes those deployments first, so no concrete test-workflow or production risk remains that should block merge.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly describes the main change: adding cert-watcher verification to operator end-to-end Kuttl tests.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The pull request description follows the required template. It explains the change, documents user-facing impact, records testing and quality checks, identifies modified tests, and provides CI validat…
Full details: Description check

Explanation

The pull request description follows the required template. It explains the change, documents user-facing impact, records testing and quality checks, identifies modified tests, and provides CI validation evidence.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

  • Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

porridge
porridge approved these changes Oct 20, 2026
View reviewed changes

@porridge porridge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please tidy up the PR description.

@vladbologa
vladbologa merged commit 0ace3de into master Oct 20, 2026
127 checks passed
@vladbologa
vladbologa deleted the vb/operator-e2e-cert-watcher branch October 20, 2026 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@porridge porridge porridge approved these changes
@johannes94 johannes94 johannes94 approved these changes
@GrimmiMeloni GrimmiMeloni Awaiting requested review from GrimmiMeloni GrimmiMeloni is a code owner automatically assigned from stackrox/install

Assignees

No one assigned

Labels

area/operator

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vladbologa @porridge @johannes94