Skip to content

ROX-37373: single node GHA GKE QA - #23496

Open
janisz wants to merge 1 commit into
masterfrom
ROX-37373/use-single-bigger-node-for-gha-qa-e2e
Open

janisz wants to merge 1 commit into
masterfrom
ROX-37373/use-single-bigger-node-for-gha-qa-e2e

Conversation

@janisz

@janisz janisz commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Description

Use a single bigger node for GHA QA E2E, it lower number of resources by using 1 node instead of 3 that is 2 times bigger then previous nodes.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Central YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 0ffc465d-2dbe-4b61-bd8a-1f67ede1f2a2
📥 Commits

Reviewing files that changed from the base of the PR and between 4c573c0 and cc651c4.

📒 Files selected for processing: 1
  • .github/workflows/e2e-qa-tests.yaml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Chores
    • The direct-GKE test cluster now uses one larger node instead of three smaller nodes.

The E2E QA workflow now configures direct-GKE clusters to use one e2-standard-16 node instead of three e2-standard-8 nodes. Infra-provisioned cluster settings are unchanged.

Changes: Direct-GKE configuration

Layer / File(s) Summary
Direct-GKE node settings
.github/workflows/e2e-qa-tests.yaml
Direct-GKE provisioning now uses one e2-standard-16 node. Infra-provisioned cluster settings are unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: mclasmeier

Merge Risk: ⚪ Minimal · up to cc651

Direct-GKE QA now uses one e2-standard-16 node instead of three e2-standard-8 nodes. No concrete workload failure is established, so no actionable merge-blocking risk is identified.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description explains the main infrastructure change and its resource goal, but required validation details are missing. The testing checkboxes remain unchecked, and the validation section still co… Replace the validation placeholder with the validation performed or explain why testing was skipped. Update the testing and quality checkboxes, including CI inspection status, and mark documentation items as not needed or provide the requir…
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly and concisely identifies the issue and the main change: using a single GKE node for GHA QA.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Description check

Explanation

The description explains the main infrastructure change and its resource goal, but required validation details are missing. The testing checkboxes remain unchecked, and the validation section still contains the placeholder "change me!".

Resolution

Replace the validation placeholder with the validation performed or explain why testing was skipped. Update the testing and quality checkboxes, including CI inspection status, and mark documentation items as not needed or provide the required links.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Build Images Ready

Images are ready for commit cc651c4. To use with deploy scripts:

export MAIN_IMAGE_TAG=5.1.x-301-gcc651c41c6

@codecov

codecov Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.96%. Comparing base (4c573c0) to head (cc651c4).
⚠️ Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #23496      +/-   ##
==========================================
- Coverage   52.00%   51.96%   -0.04%     
==========================================
  Files        2914     2914              
  Lines      183753   183753              
==========================================
- Hits        95560    95494      -66     
- Misses      79845    79891      +46     
- Partials     8348     8368      +20     
Flag Coverage Δ
go-unit-tests 51.96% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@janisz janisz added e2e-gke-upgrade-tests Triggers GHA-based gke-upgrade-tests on draft PRs e2e-qa-tests-gke e2e-qa-tests-gke-konflux e2e-qa-tests-ocp-fips-konflux Triggers GHA-based e2e-qa tests on FIPS cluster against Konflux images labels Oct 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review area/ci coderabbit-review e2e-gke-upgrade-tests Triggers GHA-based gke-upgrade-tests on draft PRs e2e-qa-tests-gke e2e-qa-tests-gke-konflux e2e-qa-tests-ocp-fips-konflux Triggers GHA-based e2e-qa tests on FIPS cluster against Konflux images

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant