Skip to content

ROX-37581: use Central-managed console proxy token role - #23445

Merged
parametalol merged 0 commit into
michael/ROX-37586-stable-metrics-registry-keyfrom
michael/ROX-37581-console-proxy-role-tokens
Oct 16, 2026
Merged

parametalol merged 0 commit into
michael/ROX-37586-stable-metrics-registry-keyfrom
michael/ROX-37581-console-proxy-role-tokens

Conversation

@parametalol

Copy link
Copy Markdown
Contributor

Description

Sensor hardcoded Deployment and Image read permissions. Request the separate Central-managed console role instead; retain namespace scoping and allow only approved read-only proxy roles. Legacy permission-based requests remain for older Sensors. A shared metrics role was unsuitable because it always grants full-cluster scope. Console tokens refresh every five minutes to reflect permission changes.

Depends on the role seeded in #23444 and the intervening metrics stack.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

  • go test ./central/auth/internaltokens/service ./sensor/common/centralproxy ./central/auth/openshift -count=1
  • go test ./central -run ^$ (compile check)
  • No benchmarks applicable.

@openshift-ci

openshift-ci Bot commented Oct 15, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

🚀 Build Images Ready

Images are ready for commit 083438a. To use with deploy scripts:

export MAIN_IMAGE_TAG=5.1.x-317-g083438a229

@parametalol
parametalol added this pull request to stack #23451 October 15, 2026 14:15
@parametalol
parametalol force-pushed the michael/ROX-37581-console-proxy-role-tokens branch from d7ee850 to 083438a Compare October 16, 2026 09:46
@parametalol
parametalol merged commit d8ce047 into michael/rox-33524-operator-central-label Oct 16, 2026
@parametalol
parametalol deleted the michael/ROX-37581-console-proxy-role-tokens branch October 16, 2026 13:42
@parametalol
parametalol force-pushed the michael/ROX-37581-console-proxy-role-tokens branch from 083438a to d8ce047 Compare October 16, 2026 13:42
@parametalol

Copy link
Copy Markdown
Contributor Author

Superseded by #23470, which carries the preparatory console-role change before #23450. GitHub marked this PR merged into its former base branch during the stack reorder; it was not merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant