ROX-36856: remove Compliance 1.0 UI service and deprecated flag by taimurhafeez · Pull Request #23360 · stackrox/stackrox

taimurhafeez · 2026-10-12T14:44:20Z

Description

Follow-up sweep after #23322 (ROX-37499), which removed the Compliance 1.0 UI. Three references survived it:

ui/apps/platform/src/services/ComplianceService.ts — the v1 REST client for /v1/compliance/standards. Verified to have zero importers across src/ and cypress/.
ROX_DEPRECATED_COMPLIANCE_DASHBOARD in pkg/features/list.go — its only consumer was the UI route gate in routePaths.ts, deleted by ROX-37499: Remove Compliance 1.0 from ui #23322, so the flag has been a no-op since then.
The same flag in tests/e2e/lib.sh (2 sites) and tests/e2e/lib-compat.sh, which exported it unconditionally.

Backend removal is deliberately not in this PR. central/compliance/ (271 files), the v1 protos, and the Splunk TA compliance feed are untouched. Follow-up PRs unregister the entry points in central/main.go and the GraphQL resolvers first, so the tree behind them becomes unreachable and can be deleted while the build stays green.

User-facing documentation

CHANGELOG.md is updated OR update is not needed
documentation PR is created and is linked above OR is not needed

No CHANGELOG entry: the flag already had no effect after #23322, so this is not user-visible on its own. Compliance 1.0 removal as a whole is covered by the epic's release notes.

Testing and quality

the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
CI results are inspected

Automated testing

No tests added: this is a deletion of dead code with no behavior to assert.

How I validated my change

grep across the repo (excluding .git/node_modules) confirms zero remaining references to DeprecatedComplianceDashboard or ROX_DEPRECATED_COMPLIANCE_DASHBOARD.
grep across ui/apps/platform/src and cypress confirms ComplianceService had no importers before deletion.
go build ./pkg/features/... and go test ./pkg/features/... pass (incl. pkg/features/telemetry, which asserts on the flag list).
bash -n passes on both edited shell scripts.
No cluster needed — no runtime behavior changes.

🤖 Generated with Claude Code

PR #23322 (ROX-37499) removed the Compliance 1.0 UI but left three references behind: ComplianceService.ts, the v1 REST client for /v1/compliance/standards, which no longer has any importers; and the ROX_DEPRECATED_COMPLIANCE_DASHBOARD feature flag, which became a no-op once its only consumer (the UI route gate) was deleted. Dropping the flag registration also means dropping it from the e2e harness, which exported it unconditionally in both the standard and compatibility paths. No CHANGELOG entry: the flag already had no effect after #23322, so this is not user-visible on its own. The Compliance 1.0 removal as a whole is covered by the epic's release notes. Scope note: the backend (central/compliance, the v1 protos, the Splunk TA compliance feed) is deliberately untouched here. Follow-up PRs unregister the entry points first so the ~271 files behind them can be deleted while the build stays green. This change was partially generated by an AI agent (Claude Code). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

openshift-ci · 2026-10-12T14:44:24Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

coderabbitai · 2026-10-12T14:45:46Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 9509a570-b5ab-4364-b6b3-7e781bcc1d7b

📥 Commits

Reviewing files that changed from the base of the PR and between 3f2514f and cf9b4f0.

📒 Files selected for processing (4)

pkg/features/list.go
tests/e2e/lib-compat.sh
tests/e2e/lib.sh
ui/apps/platform/src/services/ComplianceService.ts

💤 Files with no reviewable changes (4)

tests/e2e/lib-compat.sh
tests/e2e/lib.sh
pkg/features/list.go
ui/apps/platform/src/services/ComplianceService.ts

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review.

📝 Summary

Summary by CodeRabbit

Changes
- Removed the deprecated Compliance Dashboard feature flag and its test-environment configuration.
- Removed related compliance-standard data operations. These changes affect the former dashboard’s configuration and access to associated compliance-standard information.

The pull request removes the deprecated Compliance Dashboard feature flag from application and test configuration. It also deletes the platform compliance standards service, including its types and request functions.

Changes: Compliance feature removals

Layer / File(s)	Summary
Remove dashboard flag wiring `pkg/features/list.go`, `tests/e2e/lib-compat.sh`, `tests/e2e/lib.sh`	Removes `ROX_DEPRECATED_COMPLIANCE_DASHBOARD` registration and its test-environment and Central operator configuration entries.
Delete compliance standards service `ui/apps/platform/src/services/ComplianceService.ts`	Deletes compliance standard types and functions that fetched and sorted standards and patched `hideScanResults`.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Suggested reviewers: alanonthegit, guzalv

Merge Risk: ⚪ Minimal · up to cf9b4

No actionable merge-blocking issue is established for these removals; the PR is mergeable after normal checks.

Pre-merge checks: 5

Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Title check		The title clearly identifies the issue and the two main changes: removal of the Compliance 1.0 UI service and the deprecated feature flag.
Description check		The description explains the scope, identifies removed references, documents out-of-scope backend work, and lists validation steps. The unchecked CI inspection item is a minor omission and does not ma…

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

Commit to this branch
Create a new PR

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

_{Comment @coderabbitai help to get the list of available commands.}

taimurhafeez · 2026-10-12T14:47:26Z

/test all

github-actions · 2026-10-12T14:53:24Z

🚀 Build Images Ready

Images are ready for commit f462ad4. To use with deploy scripts:

export MAIN_IMAGE_TAG=5.1.x-276-gf462ad425a

github-actions · 2026-10-12T14:53:25Z

🚀 Build Images Ready

Images are ready for commit cf9b4f0. To use with deploy scripts:

export MAIN_IMAGE_TAG=5.1.x-233-gcf9b4f0ddd

codecov · 2026-10-12T15:12:48Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.96%. Comparing base (0fba259) to head (7924cd9).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #23360      +/-   ##
==========================================
- Coverage   52.01%   51.96%   -0.05%     
==========================================
  Files        2912     2912              
  Lines      183385   183385              
==========================================
- Hits        95381    95297      -84     
- Misses      79677    79735      +58     
- Partials     8327     8353      +26

Flag	Coverage Δ
go-unit-tests	`51.96% <ø> (-0.05%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pedrottimark

Go for it!

I will rebase deletion of ComplianceService.ts file into #23369

taimurhafeez · 2026-10-14T14:27:26Z

Go for it!

I will rebase deletion of ComplianceService.ts file into #23369

Thanks! Does CI looks good to you. If so we can merge?

openshift-ci · 2026-10-14T18:44:47Z

@taimurhafeez: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/ocp-4-12-scanner-v4-install-tests	`7924cd9`	link	false	`/test ocp-4-12-scanner-v4-install-tests`
ci/prow/ocp-4-12-nongroovy-e2e-tests	`7924cd9`	link	false	`/test ocp-4-12-nongroovy-e2e-tests`
ci/prow/ocp-4-22-nongroovy-e2e-tests	`7924cd9`	link	false	`/test ocp-4-22-nongroovy-e2e-tests`
ci/prow/ocp-4-12-qa-e2e-tests	`7924cd9`	link	false	`/test ocp-4-12-qa-e2e-tests`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci Bot added the do-not-merge/work-in-progress label Oct 12, 2026

taimurhafeez mentioned this pull request Oct 12, 2026

ROX-36856: remove Compliance 1.0 UI service and deprecated flag #23359

Closed

3 of 9 tasks

github-actions Bot added the area/ui label Oct 12, 2026

taimurhafeez added the ai-assisted label Oct 12, 2026

Merge branch 'master' into th/ROX-36856-compliance-v1-leftovers

19e7aa8

taimurhafeez marked this pull request as ready for review October 13, 2026 09:10

taimurhafeez requested review from a team as code owners October 13, 2026 09:10

openshift-ci Bot removed the do-not-merge/work-in-progress label Oct 13, 2026

taimurhafeez mentioned this pull request Oct 14, 2026

ROX-36856: retire Compliance 1.0 REST and gRPC endpoints #23399

Open

4 of 9 tasks

taimurhafeez requested review from dashrews78 and pedrottimark October 14, 2026 13:52

dashrews78 approved these changes Oct 14, 2026

View reviewed changes

pedrottimark approved these changes Oct 14, 2026

View reviewed changes

pedrottimark mentioned this pull request Oct 14, 2026

ROX-37520: Delete ROX_DEPRECATED_COMPLIANCE_DASHBOARD #23339

Closed

4 of 9 tasks

Merge branch 'master' into th/ROX-36856-compliance-v1-leftovers

7924cd9

taimurhafeez merged commit f462ad4 into master Oct 15, 2026
112 of 116 checks passed

taimurhafeez deleted the th/ROX-36856-compliance-v1-leftovers branch October 15, 2026 09:49

taimurhafeez mentioned this pull request Oct 15, 2026

ROX-36856: remove Compliance 1.0 GraphQL resolvers #23438

Open

3 of 9 tasks

Navigation Menu

Repository navigation

ROX-36856: remove Compliance 1.0 UI service and deprecated flag - #23360

ROX-36856: remove Compliance 1.0 UI service and deprecated flag#23360
taimurhafeez merged 3 commits into
masterfrom
th/ROX-36856-compliance-v1-leftovers

taimurhafeez commented Oct 12, 2026

Uh oh!

openshift-ci Bot commented Oct 12, 2026

Uh oh!

coderabbitai Bot commented Oct 12, 2026 •

edited

Loading

Summary by CodeRabbit

Uh oh!

taimurhafeez commented Oct 12, 2026

Uh oh!

github-actions Bot commented Oct 12, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 12, 2026

Uh oh!

codecov Bot commented Oct 12, 2026 •

edited

Loading

Uh oh!

pedrottimark left a comment

Uh oh!

taimurhafeez commented Oct 14, 2026

Uh oh!

openshift-ci Bot commented Oct 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

taimurhafeez commented Oct 12, 2026

Description

User-facing documentation

Testing and quality

Automated testing

How I validated my change

Uh oh!

openshift-ci Bot commented Oct 12, 2026

Uh oh!

coderabbitai Bot commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

taimurhafeez commented Oct 12, 2026

Uh oh!

github-actions Bot commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Build Images Ready

Uh oh!

github-actions Bot commented Oct 12, 2026

🚀 Build Images Ready

Uh oh!

codecov Bot commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pedrottimark left a comment

Choose a reason for hiding this comment

Uh oh!

taimurhafeez commented Oct 14, 2026

Uh oh!

openshift-ci Bot commented Oct 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai Bot commented Oct 12, 2026 •

edited

Loading

github-actions Bot commented Oct 12, 2026 •

edited

Loading

codecov Bot commented Oct 12, 2026 •

edited

Loading