Repository navigation
Conversation
|
Skipping CI for Draft Pull Request. |
Contributor
Author
|
This change is part of the following stack:
Change managed by git-spice. |
This was referenced Jun 18, 2026
Migrate from vbauerster/mpb/v4 to v8 with breaking API changes:
- BarFiller.Fill() signature changed: Fill(w, width, *Statistics) → Fill(w, Statistics) error
- Decorator.Decor() signature changed: Decor(*Statistics) string → Decor(Statistics) (string, int)
- decor.UnitKiB constant removed, replaced with decor.SizeB1024(0) function
- Updated WC embedding pattern - use WC.Format() instead of FormatMsg()/GetWidth()
- WithManualRefresh/WithShutdownNotifier now require chan interface{} instead of specific types
- Progress.Add() now returns (*Bar, error) instead of *Bar
- Added Progress.AddBar() method for default bar style
- Progress.New() for custom BarFiller implementations
Changes made:
- roxctl/central/db/restore/statusline.go: Updated Fill() method signature and error handling
- roxctl/central/db/restore/v2_restorer.go: Updated imports to v8
- roxctl/central/db/transfer/progress_bar.go: Updated Decor() and Fill() signatures, replaced UnitKiB
- roxctl/central/db/transfer/transfer.go: Updated imports to v8
All tests pass successfully.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
🚀 Build Images ReadyImages are ready for commit e03d0aa. To use with deploy scripts: export MAIN_IMAGE_TAG=4.12.x-630-ge03d0aa106 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## backoff #21261 +/- ##
========================================
Coverage 51.19% 51.19%
========================================
Files 2865 2865
Lines 178822 178825 +3
========================================
+ Hits 91541 91547 +6
+ Misses 79216 79214 -2
+ Partials 8065 8064 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate from vbauerster/mpb/v4 to v8 with breaking API changes:
Changes made:
All tests pass successfully.
Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com
Description
change me!
User-facing documentation
Testing and quality
Automated testing
How I validated my change
change me!