Skip to content

ROX-34135: Update konflux node.js build image to v22 - #19971

Merged
sachaudh merged 2 commits into
release-4.9from
bradr/release-4.9/update-nodejs-24
May 12, 2026
Merged

ROX-34135: Update konflux node.js build image to v22#19971
sachaudh merged 2 commits into
release-4.9from
bradr/release-4.9/update-nodejs-24

Conversation

@bradr5

@bradr5 bradr5 commented Apr 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Node.js 20 reaches end of support April 2026. This updates the Konflux build image to Node.js 22.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Ran npm install && npm run build locally with node 22

@bradr5
bradr5 requested a review from a team April 13, 2026 18:54
@bradr5
bradr5 requested review from a team and rhacs-bot as code owners April 13, 2026 18:54
@rhacs-bot
rhacs-bot requested a review from a team April 13, 2026 18:54
@github-actions github-actions Bot added area/helm backport PR to backport changes from master to release branch konflux-build Run Konflux in PR. Push commit to trigger it. labels Apr 13, 2026
@rhacs-bot

rhacs-bot commented Apr 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Images are ready for the commit at e8d6905.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.6-rc.1-2-ge8d6905233.

@codecov

codecov Bot commented Apr 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.87%. Comparing base (dd443c5) to head (e8d6905).

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-4.9   #19971      +/-   ##
===============================================
- Coverage        48.88%   48.87%   -0.01%     
===============================================
  Files             2719     2719              
  Lines           202912   202912              
===============================================
- Hits             99191    99174      -17     
- Misses           95955    95968      +13     
- Partials          7766     7770       +4
Flag Coverage Δ
go-unit-tests 48.87% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bradr5
bradr5 force-pushed the bradr/release-4.9/update-nodejs-24 branch from 8dcd129 to c73a34e Compare April 16, 2026 01:39
@janisz

janisz commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

Converting to draft until conflicts are resolved

@janisz
janisz marked this pull request as draft April 23, 2026 15:16
@bradr5
bradr5 force-pushed the bradr/release-4.9/update-nodejs-24 branch from c73a34e to d3b8bbf Compare April 29, 2026 01:53
@bradr5 bradr5 changed the title ROX-34135: Update konflux node.js build image to v24 ROX-34135: Update konflux node.js build image to v22 Apr 29, 2026
@bradr5
bradr5 force-pushed the bradr/release-4.9/update-nodejs-24 branch from d3b8bbf to 96fdec2 Compare April 29, 2026 04:52
msugakov
msugakov requested changes Apr 29, 2026
View reviewed changes

@msugakov msugakov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep registry.access.redhat.com if this does not fail builds.

@msugakov msugakov mentioned this pull request Apr 29, 2026
Merged
9 tasks
@bradr5
bradr5 marked this pull request as ready for review April 29, 2026 15:45
msugakov
msugakov approved these changes Apr 29, 2026
View reviewed changes

@msugakov msugakov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is happy.

@openshift-ci

openshift-ci Bot commented Apr 29, 2026

Copy link
Copy Markdown

@bradr5: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-next-candidate-qa-e2e-tests e8d6905 link false /test ocp-next-candidate-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sachaudh
sachaudh self-requested a review May 7, 2026 12:34
@sachaudh

sachaudh commented May 7, 2026

Copy link
Copy Markdown
Contributor

Reminder to self: Add this in 4.9.7 as described in this slack message.

@sachaudh
sachaudh merged commit b147b70 into release-4.9 May 12, 2026
125 of 129 checks passed
@sachaudh
sachaudh deleted the bradr/release-4.9/update-nodejs-24 branch May 12, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msugakov msugakov msugakov approved these changes
@janisz janisz janisz approved these changes
@rhacs-bot rhacs-bot Awaiting requested review from rhacs-bot rhacs-bot is a code owner
@sachaudh sachaudh Awaiting requested review from sachaudh

Assignees

No one assigned

Labels

area/helm backport PR to backport changes from master to release branch konflux-build Run Konflux in PR. Push commit to trigger it.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bradr5 @rhacs-bot @janisz @sachaudh @msugakov