ROX-34133: Use ImageVulnerabilityReportConfiguration for feature work#19970
Open
pedrottimark wants to merge 1 commit intomasterfrom
Open
ROX-34133: Use ImageVulnerabilityReportConfiguration for feature work#19970pedrottimark wants to merge 1 commit intomasterfrom
pedrottimark wants to merge 1 commit intomasterfrom
Conversation
Contributor
🚀 Build Images ReadyImages are ready for commit b23e547. To use with deploy scripts: export MAIN_IMAGE_TAG=4.11.x-636-gb23e547dd4 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19970 +/- ##
==========================================
- Coverage 49.56% 49.56% -0.01%
==========================================
Files 2764 2764
Lines 208422 208422
==========================================
- Hits 103310 103309 -1
- Misses 97457 97458 +1
Partials 7655 7655
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Frontend counterpart to backend proto changes in #19699
Additional changes:
Omit
includeWhateverproperties, because all columns become required.Rename Parameters as Filters (decided in cross-team meeting).
Decision about Destinations is pending.
Objective
Provide equivalent filter for scheduled reports as view-based reports.
Analysis
Find in Files
ReportConfiguraitonwith Match Whole Word has 39 results in 12 filesSolution
Move
EntityScopeand associated types to src/services/ReportService.ts file.Add
ImageVulnerabilityReportConfigurationtype in imageVulnerabilityReports.types.ts file for feature work.When we delete
ROX_VULNERABILITY_REPORTS_ENHANCED_FILTERINGfeature flag, either deleteReportConfigurationor factor minimal common properties.Add corresponding subset of changes for
NodeVulnerabilityReportConfigurationtype in NodeVulnerabilityReports.types.ts file for future work.Residue
User-facing documentation
Testing and quality
Automated testing
How I validated my change
npm run tscin ui/apps/platform folder.npm run lint:fast-devin ui/apps/platform folder.