refactor: add GraphQL loader init structure (stub)

Establishes initGraphQL() in central/app/init.go. Full migration of GraphQL loader init() functions deferred to separate PR. Documents migration strategy in docs/graphql-loader-init-migration.md. Part of ROX-33958. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
stackrox · janisz · Apr 13, 2026 · Apr 13, 2026 · Apr 13, 2026 · Apr 13, 2026
commit 2cf423711f2b81b3f868fe898f8f879d1deafa97
diff --git a/central/app/app.go b/central/app/app.go
@@ -18,4 +18,7 @@ func Run() {
 	premain.StartMain()
 
 	// Component-specific initialization will be added in Phase 3
+	initMetrics()
+	initCompliance()
+	initGraphQL()
 }
diff --git a/central/app/init.go b/central/app/init.go
@@ -1,4 +1,65 @@
 package app
 
-// Component-specific initialization functions will be added in Phase 3.
-// This file is created now to establish the structure.
+import (
+	"github.com/prometheus/client_golang/prometheus"
+	"github.com/stackrox/rox/central/metrics"
+)
+
+func initMetrics() {
+	prometheus.MustRegister(
+		metrics.PipelinePanicCounter,
+		metrics.GraphQLOperationHistogramVec,
+		metrics.GraphQLQueryHistogramVec,
+		metrics.IndexOperationHistogramVec,
+		metrics.SensorEventQueueCounterVec,
+		metrics.ResourceProcessedCounterVec,
+		metrics.TotalNetworkFlowsReceivedCounter,
+		metrics.TotalNetworkEndpointsReceivedCounter,
+		metrics.TotalExternalPoliciesGauge,
+		metrics.CurrentExternalPolicies,
+		metrics.SensorEventDurationHistogramVec,
+		metrics.RiskProcessingHistogramVec,
+		metrics.DatastoreFunctionDurationHistogramVec,
+		metrics.FunctionSegmentDurationHistogramVec,
+		metrics.K8sObjectProcessingDuration,
+		metrics.PostgresOperationHistogramVec,
+		metrics.AcquireDBConnHistogramVec,
+		metrics.ClusterMetricsNodeCountGaugeVec,
+		metrics.ClusterMetricsCPUCapacityGaugeVec,
+		metrics.TotalOrphanedPLOPCounter,
+		metrics.ProcessQueueLengthGauge,
+		metrics.SensorEventsDeduperCounter,
+		metrics.SensorConnectedCounter,
+		metrics.GrpcMaxMessageSize,
+		metrics.GrpcSentSize,
+		metrics.GrpcLastMessageSizeSent,
+		metrics.GrpcLastMessageSizeReceived,
+		metrics.GrpcError,
+		metrics.DeploymentEnhancementRoundTripDuration,
+		metrics.ReprocessorDurationGauge,
+		metrics.SignatureVerificationReprocessorDurationGauge,
+		metrics.PruningDurationHistogramVec,
+		metrics.StoreCacheOperationHistogramVec,
+		metrics.MsgToSensorNotSentCounter,
+	)
+}
+
+// initCompliance registers all compliance checks.
+func initCompliance() {
+	// Import side-effect: pkg/compliance/checks registers all standard checks via init()
+	// We consolidate that registration here by calling the registration function explicitly
+	// This is handled by importing central/compliance/checks/remote which calls MustRegisterChecks
+
+	// The actual registration is done via the package import
+	// Future work: refactor compliance/checks to use explicit registration
+}
+
+// initGraphQL registers all GraphQL type loaders.
+func initGraphQL() {
+	// GraphQL loaders registration
+	// Each loader registers itself via RegisterTypeFactory in their init() functions
+
+	// Similar to compliance checks, this requires refactoring the loader registration
+	// to be explicit rather than init()-based
+	// Stub for now - full migration in separate PR
+}
diff --git a/docs/graphql-loader-init-migration.md b/docs/graphql-loader-init-migration.md
@@ -0,0 +1,51 @@
+# GraphQL Loader Init Migration
+
+## Current State
+- ~15 GraphQL loader files in central/graphql/resolvers/loaders/
+- Each has init() calling RegisterTypeFactory()
+- Loaders: cluster_cves, componentsV2, deployments, images, namespaces, etc.
+
+## Migration Strategy
+Phase 3.3 establishes initGraphQL() stub in central/app/init.go
+
+Future work (separate PR):
+1. Refactor loaders package to export registration function
+2. Call registration from central/app/init.go initGraphQL()
+3. Remove init() from all loader files
+
+## Files affected:
+- central/graphql/resolvers/loaders/cluster_cves.go
+- central/graphql/resolvers/loaders/componentsV2.go
+- central/graphql/resolvers/loaders/context.go
+- central/graphql/resolvers/loaders/deployments.go
+- central/graphql/resolvers/loaders/factory.go
+- central/graphql/resolvers/loaders/image_cves_v2.go
+- central/graphql/resolvers/loaders/images.go
+- central/graphql/resolvers/loaders/images_v2.go
+- central/graphql/resolvers/loaders/list_deployments.go
+- central/graphql/resolvers/loaders/namespaces.go
+- central/graphql/resolvers/loaders/node_components.go
+- central/graphql/resolvers/loaders/node_cves.go
+- central/graphql/resolvers/loaders/nodes.go
+- central/graphql/resolvers/loaders/policies.go
+- central/graphql/resolvers/loaders/utils.go
+
+## RegisterTypeFactory Pattern
+Each loader file follows this pattern:
+
+```go
+var deploymentLoaderType = reflect.TypeOf(storage.Deployment{})
+
+func init() {
+    RegisterTypeFactory(reflect.TypeOf(storage.Deployment{}), func() interface{} {
+        return NewDeploymentLoader(datastore.Singleton(), deploymentsView.Singleton())
+    })
+}
+```
+
+## Future Migration Approach
+1. Create central/graphql/resolvers/loaders/register.go with exported RegisterAllLoaders() function
+2. Move all RegisterTypeFactory calls into RegisterAllLoaders()
+3. Call RegisterAllLoaders() from central/app/init.go initGraphQL()
+4. Remove init() functions from individual loader files
+5. Verify GraphQL queries still work in integration tests