perf(ci): Combine roxvet runs into single pass#19958
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19958 +/- ##
==========================================
+ Coverage 49.56% 49.57% +0.01%
==========================================
Files 2764 2765 +1
Lines 208357 208481 +124
==========================================
+ Hits 103276 103362 +86
- Misses 97430 97464 +34
- Partials 7651 7655 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
🚀 Build Images ReadyImages are ready for commit 13998bd. To use with deploy scripts: export MAIN_IMAGE_TAG=4.11.x-652-g13998bd1db |
5aabb57 to
18aedd0
Compare
davdhacs
approved these changes
Apr 14, 2026
dashrews78
reviewed
Apr 14, 2026
dashrews78
requested changes
Apr 14, 2026
janisz
approved these changes
Apr 14, 2026
dashrews78
reviewed
Apr 14, 2026
dashrews78
approved these changes
Apr 14, 2026
Contributor
dashrews78
left a comment
There was a problem hiding this comment.
LGTM. Thanks for humoring me on my suggestions.
vikin91
pushed a commit
that referenced
this pull request
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR optimizes the roxvet Makefile target by combining two sequential runs into a single pass, reducing execution time by ~44%.
Previously, roxvet ran twice:
donotcompareprotoandgogoprotofunctionsanalyzersThe change removes the sequential execution overhead and ensures stricter checks apply to all code.
Running all analyzers on previously-unchecked tagged files exposed violations that this PR also fixes:
testtags analyzer bug (
tools/roxvet/analyzers/testtags/analyzer.go):CommentGroup.Text()strips//prefixes, so the checkstrings.HasPrefix(comment.Text(), "//go:build")never matched. Fixed to check rawComment.Textfield instead. This was a latent bug — the analyzer was always broken, but never ran on these files before.validateimports exceptions (
tools/roxvet/analyzers/validateimports/analyzer.go):pkg/fixturesto migrator's allowed imports (used by migration tests for test data helpers)pkgto import from tools/generate-helpers/pg-table-bindings andcentral/processlisteningonport/store(test-only imports for postgres search testing)Forbidden stdlib imports (4 files): Swapped
sync→pkg/syncin test files behindsql_integrationtagsForbidden third-party import (
central/complianceoperator/v2/report/datastore/datastore_impl_test.go): Swappedgithub.com/google/uuid→pkg/uuidNeedless format calls (8 occurrences across 5 files):
fmt.Errorf("static string")→errors.New(...),fmt.Printf→fmt.PrintImport alias consistency (
tests/compliance_operator_v2_test.go): Renameddynclient→ctrlClientto match codebase conventionsort.Strings (
central/views/imagecomponentflat/view_test.go): →slices.SortAll fixes are in test files or roxvet analyzers — no production code changes.
User-facing documentation
Testing and quality
Automated testing
How I validated my change