Repository navigation
Skip UI make targets - #1849
Merged
Merged
Skip UI make targets#1849
Conversation
The `touch build` seems to be required to properly skip UI make targets if no change has been detected. Without it, the `make build` target in `ui/Makefile` is always executed, regardless of actual changes to source files. As a result, this change decreases the execution time of `make image` in most cases.
viswajithiii
approved these changes
May 25, 2022
|
Tag for build #598612 is 💻 For deploying this image using the dev scripts, run the following first: export MAIN_IMAGE_TAG='3.70.x-200-g6d039629f4'🕹️ A |
pedrottimark
approved these changes
May 26, 2022
pedrottimark
left a comment
Contributor
There was a problem hiding this comment.
Thank you for investigating the problem and finding a solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
touch buildseems to be required to properly skip UI make targetsif no change has been detected. Without it, the
make buildtarget inui/Makefileis always executed, regardless of actual changes to sourcefiles.
As a result, this change decreases the execution time of
make imageinmost cases.
Checklist
Unit test and regression tests addedEvaluated and added CHANGELOG entry if requiredDetermined and documented upgrade stepsDocumented user facing changes (create PR based on [openshift/openshift-docs](https://github.com/openshift/openshift-docs) and merge into rhacs-docs)If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.
In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.