Skip to content

chore(deps): bump Go to 1.23.6 - #14484

Merged
janisz merged 1 commit into
masterfrom
bump_go_version
Mar 7, 2025
Merged

chore(deps): bump Go to 1.23.6#14484
janisz merged 1 commit into
masterfrom
bump_go_version

Conversation

@janisz

@janisz janisz commented Mar 4, 2025

Copy link
Copy Markdown
Contributor

Description

This PR bumps Go version in builder/test images to allow upgrading cosign:

Testing

  • inspected CI results

Automated testing

  • modified existing tests
  • contributed no automated tests

How I validated my change

CI

@janisz
janisz requested a review from a team as a code owner March 4, 2025 12:25
@janisz
janisz requested review from erthalion and removed request for a team March 4, 2025 12:25
@janisz
janisz requested review from BradLugo, RTann and rhybrillou March 4, 2025 12:25
janisz
janisz commented Mar 4, 2025
View reviewed changes
Comment thread BUILD_IMAGE_VERSION Outdated
rhybrillou
rhybrillou reviewed Mar 4, 2025
View reviewed changes

@rhybrillou rhybrillou left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about these files ?

.devcontainer/devcontainer.json
.github/workflows/fixxxer.yaml
.openshift-ci/Dockerfile.build_root

@codecov

codecov Bot commented Mar 4, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.11%. Comparing base (6e945b7) to head (0ca41db).
Report is 26 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #14484   +/-   ##
=======================================
  Coverage   49.10%   49.11%           
=======================================
  Files        2522     2522           
  Lines      184227   184227           
=======================================
+ Hits        90468    90478   +10     
+ Misses      86557    86549    -8     
+ Partials     7202     7200    -2
Flag Coverage Δ
go-unit-tests 49.11% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@janisz
janisz force-pushed the bump_go_version branch from d037a31 to eff7e3b Compare March 4, 2025 17:37
@janisz

janisz commented Mar 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This change is part of the following stack:

Change managed by git-spice.

@janisz janisz mentioned this pull request Mar 4, 2025
Merged
5 tasks done
BradLugo
BradLugo reviewed Mar 4, 2025
View reviewed changes
Comment thread BUILD_IMAGE_VERSION Outdated
BradLugo
BradLugo reviewed Mar 4, 2025
View reviewed changes

@BradLugo BradLugo left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can bump the image version to 0.4.8. Shouldn't matter though.

Do we need to change the toolchain directive in go.mod? Looks like that change is in the other PR (#14430)

@janisz
janisz force-pushed the bump_go_version branch from eff7e3b to 12f5002 Compare March 5, 2025 11:53
@janisz
janisz requested review from BradLugo and rhybrillou March 5, 2025 11:54
@rhybrillou

rhybrillou commented Mar 5, 2025

Copy link
Copy Markdown
Contributor

How about these files ?

.devcontainer/devcontainer.json
.github/workflows/fixxxer.yaml
.openshift-ci/Dockerfile.build_root

@janisz
janisz force-pushed the bump_go_version branch from 12f5002 to 5ada47a Compare March 5, 2025 15:59
@janisz

janisz commented Mar 5, 2025

Copy link
Copy Markdown
Contributor Author

/retest

@janisz janisz added the auto-merge Auto-merge minor and patch version bumps label Mar 5, 2025
@janisz
janisz force-pushed the bump_go_version branch from 5ada47a to 034419d Compare March 5, 2025 18:49
@janisz
janisz requested a review from a team as a code owner March 5, 2025 18:49
@janisz
janisz requested review from porridge and removed request for a team March 5, 2025 18:49
@janisz
janisz force-pushed the bump_go_version branch 2 times, most recently from 2b41a5e to 034419d Compare March 5, 2025 18:54
@janisz janisz mentioned this pull request Mar 5, 2025
Merged
5 tasks done
@janisz
chore(deps): bump Go to 1.23.6
0ca41db 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz
janisz force-pushed the bump_go_version branch from 034419d to 0ca41db Compare March 5, 2025 18:58
@rhacs-bot

rhacs-bot commented Mar 5, 2025

Copy link
Copy Markdown
Contributor

Images are ready for the commit at 0ca41db.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-153-g0ca41db2e7.

porridge
porridge reviewed Mar 6, 2025
View reviewed changes

@porridge porridge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI does not look too happy 😟
Also, I wonder whether we should have a CI check that does grep -ER stackrox-(build|test)-\d+ and makes sure the version is consistent...

Comment thread go.mod
@RTann

RTann commented Mar 6, 2025

Copy link
Copy Markdown
Contributor

I think we may need openshift/release#62496 merged for CI to work. I held that from getting merged until this PR is ready. Feel free to /unhold that PR when ready

@janisz

janisz commented Mar 7, 2025

Copy link
Copy Markdown
Contributor Author

/retest

@janisz

janisz commented Mar 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

CI does not look too happy 😟

The problem was with disk space not the go version itself :(

Also, I wonder whether we should have a CI check that does grep -ER stackrox-(build|test)-\d+ and makes sure the version is consistent...

I also thought about this and some way of automation around upgrading the go. Maybe instead of having it in the image we can download it at build time (toolchain or even bash download) so we need only 1 PR to bump go instead of 4

  1. Bump go to 1.23.6 rox-ci-image#223
  2. stackrox: mirror 4.8 images openshift/release#62348
  3. update stackrox test images to 0.4.8 openshift/release#62496
  4. chore(deps): bump Go to 1.23.6 #14484

@janisz
janisz requested a review from porridge March 7, 2025 13:16
@janisz

janisz commented Mar 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

The check could look like this

git grep -E -o -h '(stackrox|scanner)-(build|test)-0.[0-9]+\.[0-9]' | grep -E -o '0.[0-9]+\.[0-9]' | sort -u | wc -l

and expected output is 1

@janisz janisz mentioned this pull request Mar 7, 2025
Merged
5 tasks done
@janisz
janisz merged commit a8cb8a8 into master Mar 7, 2025
@janisz
janisz deleted the bump_go_version branch March 7, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhybrillou rhybrillou rhybrillou approved these changes
@erthalion erthalion Awaiting requested review from erthalion
@RTann RTann Awaiting requested review from RTann
@BradLugo BradLugo Awaiting requested review from BradLugo
@porridge porridge Awaiting requested review from porridge

Assignees

No one assigned

Labels

area/ci area/operator auto-merge Auto-merge minor and patch version bumps

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@janisz @rhybrillou @rhacs-bot @RTann @porridge @BradLugo