Skip to content

fix(test): load unit test metrics into bq - #10474

Merged
janisz merged 9 commits into
masterfrom
load_unit-test-results-into-giqquery
Mar 28, 2024
Merged

fix(test): load unit test metrics into bq#10474
janisz merged 9 commits into
masterfrom
load_unit-test-results-into-giqquery

Conversation

@janisz

@janisz janisz commented Mar 21, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR enhance junit2jira action with uploading test metrics into bigquery.

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

SELECT JobName FROM `acs-san-stackroxci.ci_metrics.stackrox_tests`
WHERE BuildTag = '10474/merge@ffeacd0b325c0fcc4a9c997c325db4d549377317'
GROUP BY JobName
Row	| JobName
1       | ui
2       | shell-unit-tests
3       | go
4       | local-roxctl-tests
5       | go-postgres

Here I tell how I validated my change

Reminder for reviewers

In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

@rhacs-bot

rhacs-bot commented Mar 21, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Images are ready for the commit at 47fe6d1.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.4.x-277-g47fe6d1d45.

@codecov

codecov Bot commented Mar 21, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.89%. Comparing base (b8a948e) to head (47fe6d1).
Report is 5 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #10474      +/-   ##
==========================================
- Coverage   47.89%   47.89%   -0.01%     
==========================================
  Files        2280     2280              
  Lines      163224   163224              
==========================================
- Hits        78179    78169      -10     
- Misses      78843    78851       +8     
- Partials     6202     6204       +2
Flag Coverage Δ
go-unit-tests 47.89% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janisz
janisz requested review from a team, gavin-stackrox, porridge and rukletsov March 22, 2024 15:04
@janisz
janisz enabled auto-merge (squash) March 25, 2024 12:31
gavin-stackrox
gavin-stackrox suggested changes Mar 25, 2024
View reviewed changes

@gavin-stackrox gavin-stackrox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR should also handle create_job_record() and update_job_record(). Current reporting depends on it and the job record has more detail related to the overall run. Support for GHA might be missing though.

porridge
porridge approved these changes Mar 26, 2024
View reviewed changes

@porridge porridge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nitpicks. No idea about the thing mentioned by Gavin...

Comment thread .github/actions/junit2jira/action.yaml Outdated
Comment thread .github/actions/junit2jira/action.yaml Outdated
Comment thread .github/actions/junit2jira/action.yaml Outdated
@janisz

janisz commented Mar 27, 2024

Copy link
Copy Markdown
Contributor Author

@gavin-stackrox How about adding support for job records in a separated PR. Currently pre/post actions are not supported in composite action so we need to rewrite junit2jira action to have it or create a dedicated action for job record

janisz and others added 9 commits March 27, 2024 13:16
@janisz
fix(test): load unit test metrics into bq
6a50d42 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz
allow dry-run
6e2b89e 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz
run dry on PR
6c33358 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz
provide a secret
2647695 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz
fix
26d7643 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz
echo
7811edb 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz
remove line
cf3191c 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz @porridge
Apply suggestions from code review
82cd91c 
Co-authored-by: Marcin Owsiany <porridge@redhat.com>
@janisz
remove line
47fe6d1 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz
janisz force-pushed the load_unit-test-results-into-giqquery branch from dfd4b37 to 47fe6d1 Compare March 27, 2024 12:17
@janisz
janisz merged commit 2eba1e9 into master Mar 28, 2024
@janisz
janisz deleted the load_unit-test-results-into-giqquery branch March 28, 2024 10:00
janisz added a commit that referenced this pull request Mar 28, 2024
@janisz
Revert "fix(test): load unit test metrics into bq (#10474)"
4000286 
This reverts commit 2eba1e9.
@janisz janisz mentioned this pull request Mar 28, 2024
Closed
dcaravel pushed a commit that referenced this pull request May 15, 2024
@janisz @dcaravel
fix(test): load unit test metrics into bq (#10474)
3580476 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@porridge porridge porridge approved these changes
@rukletsov rukletsov Awaiting requested review from rukletsov
+1 more reviewer
@gavin-stackrox gavin-stackrox gavin-stackrox approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/ci

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@janisz @rhacs-bot @porridge @gavin-stackrox