Repository navigation
test(sqlrewrite): add unit tests for package sqlrewrite - #847
Merged
general-kroll-4-life merged 1 commit intoOct 15, 2026
Merged
Conversation
general-kroll-4-life
approved these changes
Oct 15, 2026
Contributor
|
@RyoKusnadi thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package
internal/stackql/sqlrewritehad no unit tests. This PR adds them.What I added:
One new file,
sqlrewrite_test.go. It has one table-driven test forGenerateRewrittenSelectDML. Each row in the table is one case, and every case runs the same way. The test uses small fake objects in place of the real SQL system, config and tables, so it does not need a database.The four cases:
ComposeSelectQueryunchanged.ComposeSelectQueryis returned to the caller.I did not change any production code.
Results: all tests pass,
go test -cover ./internal/stackql/sqlrewrite/...shows 96.4% coverage (the issue asks for 85%), andgolangci-lintv2.5.0 reports no issues for this package.Note: another contributor took this issue in July. If they are still working on it, I'm happy to close this PR.
Fixes #268