Skip to content

finalize-pure-go-sqlite-migration-cleanup - #785

Merged
jeffreyaven merged 2 commits into
feat/gosqlite-migrationfrom
copilot/featgosqlite-migration
Sep 21, 2026
Merged

jeffreyaven merged 2 commits into
feat/gosqlite-migrationfrom
copilot/featgosqlite-migration

Conversation

Copilot AI commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Description

Completes the pre-main review of the pure-Go SQLite migration without changing runtime behavior, dependencies, or fixtures.

  • Build configuration: Set remaining Goreleaser targets to CGO_ENABLED=0 and remove obsolete C compiler settings.
  • Dead references: Remove retired sqlite_stackql VS Code flags and stale internal/sqlfuncs agent documentation.
  • Repository hygiene: Restore test/robot/reports/.gitignore.

Type of change

  • Bug fix (non-breaking change to fix a bug).
  • Feature (non-breaking change to add functionality).
  • Breaking change.
  • Other (eg: documentation change). Pure-Go migration cleanup.

Issues referenced.

None.

Evidence

  • go build ./...
  • go test ./...
  • golangci-lint run --timeout 20m
  • actionlint -color
  • CodeQL: no alerts
  • Retired SQLite modules and build-tag references absent

Checklist:

  • A full round of testing has been completed, and there are no test failures as a result of these changes.
  • The changes are covered with functional and/or integration robot testing.
  • The changes work on all supported platforms.
  • Unit tests pass locally, as per the developer guide.
  • Robot tests pass locally, as per the developer guide.
  • Linter passes locally, as per the developer guide.

Variations

Cross-platform validation awaits approval of the gated CI runs. The existing 651/651 robot result remains applicable because this cleanup changes only tooling and documentation.

Tech Debt

None added. The intentional prerelease any-sdk pin remains for a post-merge stable-version update.

Copilot AI and others added 2 commits September 21, 2026 02:22
Co-authored-by: jeffreyaven <5146499+jeffreyaven@users.noreply.github.com>
Co-authored-by: jeffreyaven <5146499+jeffreyaven@users.noreply.github.com>
Copilot AI changed the title migrate-embedded-sqlite-to-pure-go-modernc finalize-pure-go-sqlite-migration-cleanup Sep 21, 2026
Copilot AI requested a review from jeffreyaven September 21, 2026 02:48
@jeffreyaven
jeffreyaven marked this pull request as ready for review September 21, 2026 02:49
@jeffreyaven
jeffreyaven merged commit fc827f5 into feat/gosqlite-migration Sep 21, 2026
3 of 4 checks passed
@jeffreyaven
jeffreyaven deleted the copilot/featgosqlite-migration branch September 21, 2026 02:54
Copilot stopped work on behalf of jeffreyaven due to an error September 21, 2026 02:54
Copilot AI requested a review from jeffreyaven September 21, 2026 02:54
jeffreyaven added a commit that referenced this pull request Sep 21, 2026
* modernc sqlite migration prep

* migrate-embedded-sqlite-to-pure-go-modernc (#783)

* docs(sqlfuncs): mirror CLAUDE.md as AGENTS.md for all agent sessions

Co-authored-by: jeffreyaven <5146499+jeffreyaven@users.noreply.github.com>

* deps: adopt any-sdk pure-Go sqlite backend, drop mattn/cgo fork replace

Co-authored-by: jeffreyaven <5146499+jeffreyaven@users.noreply.github.com>

* ci: retire cgo - CGO_ENABLED=0, drop C toolchains and sqlite_stackql tag, add per-artifact function smoke

Co-authored-by: jeffreyaven <5146499+jeffreyaven@users.noreply.github.com>

* docs+test: modernc backend invariants, release notes draft, robot ext-function smoke scenario

Co-authored-by: jeffreyaven <5146499+jeffreyaven@users.noreply.github.com>

* deps: bump any-sdk to alpha02 (aws_policy_equal tags parity, boolean decltype); pin sqlite_version fixture to 3.53.4

Co-authored-by: jeffreyaven <5146499+jeffreyaven@users.noreply.github.com>

* burn: remove executed migration work order

Co-authored-by: jeffreyaven <5146499+jeffreyaven@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: jeffreyaven <5146499+jeffreyaven@users.noreply.github.com>

* finalize-pure-go-sqlite-migration-cleanup (#785)

* retire remaining cgo configuration and stale migration artifacts

Co-authored-by: jeffreyaven <5146499+jeffreyaven@users.noreply.github.com>

* preserve migration smoke-test documentation

Co-authored-by: jeffreyaven <5146499+jeffreyaven@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: jeffreyaven <5146499+jeffreyaven@users.noreply.github.com>

* shard-postgres-docker-robot-tests

Co-authored-by: jeffreyaven <5146499+jeffreyaven@users.noreply.github.com>

* keep-stateful-robot-tests-in-one-shard

Co-authored-by: jeffreyaven <5146499+jeffreyaven@users.noreply.github.com>

* rename-release-process-doc-without-spaces

Rename `docs/stackql release process.md` to
`docs/stackql_release_process.md` per review, and update the three
references to it (two workflow header comments and the mcpb packaging
notes) so nothing points at the old name.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* move-extension-function-smoke-to-robot

Remove the six workflow-level extension function smoke steps from
build.yml per review. The check lives in the robot scenario
`Sqlite Extension Functions Smoke Working`, which now carries the
stronger aws_policy_equal comparison the workflow steps used (Version
plus scalar-vs-array Resource), so nothing is lost in the move.

The scenario runs wherever the functional suite runs: winbuild,
linuxtest, linuxarmbuild, macosbuild, wsltest and the docker sqlite leg.
winarmsmoke and macosarmbuild have no robot harness, so the check is no
longer exercised in those two jobs.

Also drop the stale "cgo" wording from the winarmsmoke comment.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* assert-shard-completeness-after-docker-tests

Sharding splits one robot run across several dockertest legs, so no
single leg can attest that the whole suite ran. Add a dockertestverify
job that runs once all legs conclude and fails unless, for each
(platform, db backend) group, the shards together account for every
functional test exactly once.

- Each robot-running dockertest leg uploads its output.xml; unsharded
  legs upload as shard 1 of 1.
- robot_shard.py gains a verifier. The expected tests are parsed from
  test/robot/functional with no shard modifier applied, then compared
  as a multiset against the union of the shard reports, so the total
  count and each individual test are checked independently.
- Anything that prevents verification fails it: absent shard, absent
  output.xml, inconsistent shard counts, a NOT RUN test, an expected
  group with no reports, or reports from a group that is not listed.
- dockermerge now needs dockertestverify, so an image cannot be pushed
  past a failed verification.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* run-robot-suite-on-arm-runners

Per review: now that GitHub hosts arm64 macOS and Windows runners, run
the robot functional suite on both rather than leaving the extension
function check unexercised there.

- macosarmbuild: mirror the macosbuild robot harness (libpq, python
  deps, registry rewrite, certificates, robot run, report upload). The
  libpq path is resolved with `brew --prefix` because homebrew's prefix
  differs on Apple Silicon.
- winarmsmoke: mirror the winbuild robot harness against the amd64
  binary under x64 emulation. Python is x64 because psycopg2-binary,
  psycopg-binary and cryptography publish no win_arm64 wheels. The job
  now checks out the repo (before the artifact downloads, since checkout
  cleans the workspace) and moves from the short to the standard job
  timeout.
- winbuild: upload the MCP client as an artifact so the MCP scenarios
  run in winarmsmoke rather than being skipped.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: jeffreyaven <5146499+jeffreyaven@users.noreply.github.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants