Skip to content

fix lint: satisfy nilnil in internaldto tests; drop PR_README.md (#235) - #767

Merged
jeffreyaven merged 5 commits into
stackql:mainfrom
Sneha41sb:unit-tests-suite-2
Sep 17, 2026
Merged

jeffreyaven merged 5 commits into
stackql:mainfrom
Sneha41sb:unit-tests-suite-2

Conversation

@Sneha41sb

@Sneha41sb Sneha41sb commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

This PR fixes lint warnings in the unit test files added in the previous PR (#235)

Changes:

  • internal/stackql/internal_data_transfer/internaldto/internaldto_test.go: Added //nolint:nilnil comments to 3 function literals where a nil return value is intentionally passed as a non-error return value, silencing false positive nilnil linter warnings.

Type of change

  • Bug fix (non-breaking change to fix a bug).
  • Feature (non-breaking change to add functionality).
  • Breaking change.
  • Other (eg: documentation change). Please explain: lint fix and file cleanup.

Issues referenced

Evidence

Local lint run with golangci-lint run — no warnings from the modified file. Full local test suite passing:

$ go test --tags sqlite_stackql ./...
ok github.com/stackql/stackql/internal/stackql/internal_data_transfer/internaldto 0.020s
ok github.com/stackql/stackql/internal/stackql/iqlerror 0.003s
ok github.com/stackql/stackql/internal/stackql/kstore 0.005s
ok github.com/stackql/stackql/internal/stackql/metadatavisitors 0.042s
ok github.com/stackql/stackql/internal/stackql/nativedb 0.003s
ok github.com/stackql/stackql/internal/stackql/providerconfig 0.004s
ok github.com/stackql/stackql/internal/stackql/sqlstream 0.041s
ok github.com/stackql/stackql/pkg/textutil 0.004s
ok github.com/stackql/stackql/pkg/txncounter 0.004s
ok github.com/stackql/stackql/pkg/sqltypeutil 0.009s
... (all other packages pass)

Checklist:

  • A full round of testing has been completed, and there are no test failures as a result of these changes.
  • The changes are covered with functional and/or integration robot testing.
  • The changes work on all supported platforms.
  • Unit tests pass locally, as per the developer guide.
  • Robot tests pass locally, as per the developer guide.
  • Linter passes locally, as per the developer guide.

Sneha41sb and others added 5 commits September 6, 2026 14:08
The five auth stub closures in internaldto_test.go returned (nil, nil),
which the repo's golangci-lint config rejects via the nilnil linter.
Return an empty *dto.AuthCtx instead; the assertions do not depend on
the value.

PR_README.md was a copy of the PR description and does not belong in
the tree.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@jeffreyaven
jeffreyaven merged commit 09cdd81 into stackql:main Sep 17, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants