Repository navigation
fix lint: satisfy nilnil in internaldto tests; drop PR_README.md (#235) - #767
Merged
Merged
Conversation
The five auth stub closures in internaldto_test.go returned (nil, nil), which the repo's golangci-lint config rejects via the nilnil linter. Return an empty *dto.AuthCtx instead; the assertions do not depend on the value. PR_README.md was a copy of the PR description and does not belong in the tree. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
jeffreyaven
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes lint warnings in the unit test files added in the previous PR (#235)
Changes:
Type of change
Issues referenced
primitive_context#235 — Unit testing for package internaldto (internal_data_transfer/internaldto)Evidence
Local lint run with golangci-lint run — no warnings from the modified file. Full local test suite passing:
$ go test --tags sqlite_stackql ./...
ok github.com/stackql/stackql/internal/stackql/internal_data_transfer/internaldto 0.020s
ok github.com/stackql/stackql/internal/stackql/iqlerror 0.003s
ok github.com/stackql/stackql/internal/stackql/kstore 0.005s
ok github.com/stackql/stackql/internal/stackql/metadatavisitors 0.042s
ok github.com/stackql/stackql/internal/stackql/nativedb 0.003s
ok github.com/stackql/stackql/internal/stackql/providerconfig 0.004s
ok github.com/stackql/stackql/internal/stackql/sqlstream 0.041s
ok github.com/stackql/stackql/pkg/textutil 0.004s
ok github.com/stackql/stackql/pkg/txncounter 0.004s
ok github.com/stackql/stackql/pkg/sqltypeutil 0.009s
... (all other packages pass)
Checklist: