Repository navigation
feat: add goreleaser - #334
Merged
Merged
Conversation
- Add config for linux release - Add config for darwin release - Add config for windows release - Add build workflows
Iqbalabdi
marked this pull request as ready for review
November 27, 2023 12:51
Contributor
|
@Iqbalabdi thank you for submitting. Shall review this; will probably take a while |
general-kroll-4-life
requested changes
Dec 3, 2023
general-kroll-4-life
left a comment
Contributor
There was a problem hiding this comment.
@Iqbalabdi nice work! General observation is that we want to perform (i) unit tests, (ii) robot tests on all goreleaser-generated artifacts. This we can do in future Pull Requests. Please address the one requested change for now that should be fine. Thanks again, not least for being patient.
Contributor
Author
|
done. please review |
general-kroll-4-life
approved these changes
Dec 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added Goreleaser
CCandCXX) for each platform.build.yamlto build the binary.tagsevent and hasn't affected the main workflows.Goreleaser build includes:
.deb,.rpm,.apk, and Archlinux packagesExcluded:
The reason for exclusions:
env, it should be executed like this. However, since this build uses goreleaser-action, the run cannot be executed.Type of Change
Issues Referenced
[Feat] Issue: #224
Evidence
See more on this release.
Checklist:
Variations
ldflagsfor the binary use field templates from Goreleaser, not using environment variables from runner/host.Tech Debt