Skip to content

case-sensitive-select-expressions - #137

Merged
general-kroll-4-life merged 1 commit into
mainfrom
bugfix/capitalisation-select-expressions
Feb 8, 2023
Merged

general-kroll-4-life merged 1 commit into
mainfrom
bugfix/capitalisation-select-expressions

Conversation

@general-kroll-4-life

@general-kroll-4-life general-kroll-4-life commented Feb 8, 2023 •

Copy link
Copy Markdown
Contributor

Description

  • Amended postgres rewriting formatter to surround column names with double quotes.
  • This supports queries against columns that are not uniformly cased, when using a postgres backend.
  • Robot tests Google AcceleratorTypes SQL verb pre changeover and Google AcceleratorTypes SQL verb post changeover now include the variably cased maximumCardsPerInstance column, to demonstrate the fix is successful.

Type of change

  • Bug fix (non-breaking change to fix a bug).
  • Feature (non-breaking change to add functionality).
  • Breaking change.
  • Other (eg: documentation change). Please explain.

Issues referenced.

N/A

Evidence

Please see outcome of tests from Run POSTGRES BACKEND robot mocked functional tests step of Docker Build job in PR actions:

  • Google AcceleratorTypes SQL verb pre changeover
  • Google AcceleratorTypes SQL verb post changeover

Checklist:

  • A full round of testing has been completed, and there are no test failures as a result of these changes.
  • The changes are covered with functional and/or integration robot testing.
  • The changes work on all supported platforms.

Variations

N/A

Tech Debt

This change does not add new tech debt; rather, it addresses existing tech debt.

@general-kroll-4-life
general-kroll-4-life force-pushed the bugfix/capitalisation-select-expressions branch 2 times, most recently from ef3fdce to d6cd9cb Compare February 8, 2023 11:24
Summary:

- Amended `postgres` rewriting formatter to surround column names with double quotes.
- This supports queries against columns that are not uniformly cased, when using a `postgres` backend.
- Robot test `PG Session Postgres Client V2 Typed Queries` un-skipped to demonstrate the fix is successful.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant